DHLGW-1164: list only applicable orders in interactive form

Author: Sebastian80

Controller/Adminhtml/Shipment/Interactive.php

@@ -16,6 +16,7 @@
 use Magento\Sales\Model\ResourceModel\Order\CollectionFactory;
 use Magento\Ui\Component\MassAction\Filter;
 use Netresearch\InteractiveBatchProcessing\Model\OrderProvider;
+use Netresearch\ShippingCore\Api\BulkShipment\OrderLoaderInterface;
 
 /**
  * @method Http getRequest()
@@ -37,15 +38,22 @@ class Interactive extends Action implements HttpPostActionInterface
      */
     private $orderProvider;
 
+    /**
+     * @var OrderLoaderInterface
+     */
+    private $orderLoader;
+
     public function __construct(
         Context $context,
         CollectionFactory $collectionFactory,
         Filter $filter,
-        OrderProvider $orderProvider
+        OrderProvider $orderProvider,
+        OrderLoaderInterface $orderLoader
     ) {
         $this->collectionFactory = $collectionFactory;
         $this->filter = $filter;
         $this->orderProvider = $orderProvider;
+        $this->orderLoader = $orderLoader;
 
         parent::__construct($context);
     }
@@ -59,15 +67,21 @@ public function execute()
         $this->_setActiveMenu('Magento_Sales::sales_order');
         $this->_view->getPage()->getConfig()->getTitle()->prepend(__('Bulk Shipment'));
 
-        // todo(nr): filter applicable orders (label status, carrier code)
-        // @see \Netresearch\ShippingCore\Model\BulkShipment\BulkShipmentManagement::createShipments
         $orderCollection = $this->filter->getCollection($this->collectionFactory->create());
+        $orders = $this->orderLoader->load($orderCollection->getAllIds());
 
         // the "Create New Order" UI button gets added by using the UI filter above…
         $this->_view->getLayout()->unsetElement('container-sales_order_grid-add');
 
-        // todo(nr): if order collection is empty, redirect to grid.
-        $this->orderProvider->setOrders($orderCollection->getItems());
+        if (empty($orders)) {
+            $this->messageManager->addNoticeMessage(__('Selected orders cannot be processed.'));
+            $resultRedirect = $this->resultRedirectFactory->create();
+            $resultRedirect->setPath('sales/order');
+
+            return $resultRedirect;
+        }
+
+        $this->orderProvider->setOrders($orders);
 
         return $this->_view->getPage();
     }

i18n/de_DE.csv

@@ -4,3 +4,4 @@
 "Enable Interactive Mass Action","Interaktive Massenaktion aktivieren"
 "If you want to select packaging or shipping product per order, then it is recommended to enable interactive mass action and to disable fully automated cron processing.","Falls Sie beim Versand Paketgröße oder Versandprodukt je Bestellung festlegen wollen, dann wird empfohlen, die interaktive Massenverarbeitung zu aktivieren und das vollautomatische Erzeugen von Versandetiketten via Cron zu deaktivieren."
 "Items to Ship","Zu versendende Artikel"
+"Selected orders cannot be processed.","Die gewählten Bestellungen können nicht verarbeitet werden."

i18n/en_US.csv

@@ -4,3 +4,4 @@
 "Enable Interactive Mass Action","Enable Interactive Mass Action"
 "If you want to select packaging or shipping product per order, then it is recommended to enable interactive mass action and to disable fully automated cron processing.","If you want to select packaging or shipping product per order, then it is recommended to enable interactive mass action and to disable fully automated cron processing."
 "Items to Ship","Items to Ship"
+"Selected orders cannot be processed.","Selected orders cannot be processed."