DHLGW-1429: Upgrade module for Magento 2.4.8 PHP 8.3/8.4 compatibility

Author: Sebastian80

Block/Adminhtml/Container/Confirm.php

@@ -20,6 +20,7 @@ class Confirm extends Container
      *
      * @return void
      */
+    #[\Override]
     protected function _construct()
     {
         $this->_controller = 'adminhtml';
@@ -31,6 +32,7 @@ protected function _construct()
         $this->removeButton('reset');
     }
 
+    #[\Override]
     public function getBackUrl()
     {
         return $this->getUrl('sales/order/index');

Block/Adminhtml/Data/Form/Confirm.php

@@ -45,6 +45,7 @@ private function getTableHtml(): string
      * @return string
      * @throws LocalizedException
      */
+    #[\Override]
     public function toHtml()
     {
         Profiler::start('form/toHtml');
@@ -53,7 +54,7 @@ public function toHtml()
         if ($useContainer) {
             $html .= '<form ' . $this->serialize($this->getHtmlAttributes()) . '>';
             $html .= '<div>';
-            if (strtolower($this->getData('method')) === 'post') {
+            if (strtolower((string) $this->getData('method')) === 'post') {
                 $html .= '<input name="form_key" type="hidden" value="' . $this->formKey->getFormKey() . '" />';
             }
             $html .= '</div>';

Block/Adminhtml/Widget/Form.php

@@ -144,6 +144,7 @@ private function addSelectCell(
     /**
      * @throws LocalizedException
      */
+    #[\Override]
     protected function _prepareForm(): self
     {
         $orders = $this->selectedOrders->get();
@@ -168,6 +169,7 @@ protected function _prepareForm(): self
     /**
      * @throws LocalizedException
      */
+    #[\Override]
     protected function _prepareLayout(): self
     {
         parent::_prepareLayout();

Block/Adminhtml/Widget/Form/Renderer/TableRow.php

@@ -36,6 +36,7 @@ public function getElement(): AbstractElement
      * @param AbstractElement $element
      * @return string
      */
+    #[\Override]
     public function render(AbstractElement $element)
     {
         $this->_element = $element;

Controller/Adminhtml/Shipment/Interactive.php

@@ -12,6 +12,7 @@
 use Magento\Backend\App\Action\Context;
 use Magento\Framework\App\Action\HttpPostActionInterface;
 use Magento\Framework\App\Request\Http;
+use Magento\Framework\Controller\ResultInterface;
 use Magento\Framework\Exception\LocalizedException;
 use Magento\Sales\Model\ResourceModel\Order\CollectionFactory;
 use Magento\Ui\Component\MassAction\Filter;
@@ -61,7 +62,8 @@ public function __construct(
     /**
      * @throws LocalizedException
      */
-    public function execute()
+    #[\Override]
+    public function execute(): ResultInterface
     {
         $this->_view->loadLayout();
         $this->_setActiveMenu('Magento_Sales::sales_order');

Controller/Adminhtml/Shipment/Submit.php

@@ -31,7 +31,8 @@ public function __construct(Context $context, SelectedShippingSettings $settings
         parent::__construct($context);
     }
 
-    public function execute()
+    #[\Override]
+    public function execute(): void
     {
         $inputValues = $this->getRequest()->getParam('inputs', []);
         foreach ($inputValues as $orderId => $orderInputValues) {

Model/ShippingSettings/TypeProcessor/ShippingOptions/UpdateInputDefaultsProcessor.php

@@ -50,13 +50,14 @@ private function getOptionInput(ShippingOptionInterface $serviceOption, string $
      *
      * @return ShippingOptionInterface[]
      */
+    #[\Override]
     public function process(
         string $carrierCode,
         array $shippingOptions,
         int $storeId,
         string $countryCode,
         string $postalCode,
-        ShipmentInterface $shipment = null
+        ?ShipmentInterface $shipment = null
     ): array {
         if (!$shipment) {
             // checkout scope, nothing to modify.

Model/ShippingSettings/TypeProcessor/ShippingOptions/UpdatePackageDimensionsProcessor.php

@@ -120,13 +120,14 @@ private function processInputs(ShippingOptionInterface $shippingOption, Shipment
      *
      * @return ShippingOptionInterface[]
      */
+    #[\Override]
     public function process(
         string $carrierCode,
         array $shippingOptions,
         int $storeId,
         string $countryCode,
         string $postalCode,
-        ShipmentInterface $shipment = null
+        ?ShipmentInterface $shipment = null
     ): array {
         if (!$shipment) {
             // checkout scope, nothing to modify.

Ui/Component/MassAction/InteractiveBatchProcessing.php

@@ -39,6 +39,7 @@ public function __construct(
         parent::__construct($context, $components, $data, $actions);
     }
 
+    #[\Override]
     public function prepare()
     {
         parent::prepare();

composer.json

@@ -21,13 +21,13 @@
         ]
     },
     "require": {
-        "php": "^8.2.0",
-        "magento/framework": "^103.0.6",
-        "magento/module-backend": "^102.0.6",
-        "magento/module-config": "^101.2.6",
-        "magento/module-sales": "^103.0.6",
-        "magento/module-store": "^101.1.6",
-        "magento/module-ui": "^101.1.6",
-        "netresearch/module-shipping-core": "^3.0.0"
+        "php": "^8.3.0 || ^8.4.0",
+        "magento/framework": "^103.0.8",
+        "magento/module-backend": "^102.0.8",
+        "magento/module-config": "^101.2.8",
+        "magento/module-sales": "^103.0.8",
+        "magento/module-store": "^101.1.8",
+        "magento/module-ui": "^101.1.8",
+        "netresearch/module-shipping-core": "^3.2.0"
     }
 }