fix: address review comments on test quality

- Mock FetchAdapter to assert correct URL for each environment
- Use mockImplementation for getPackageBySubmissionId to return
  distinct objects per submission ID

Author: CybotTM

src/__tests__/EQP.test.ts

@@ -1,38 +1,44 @@
 import { describe, it, expect, vi, beforeEach } from 'vitest';
 import { EQP } from '../index';
+import { FetchAdapter } from '../FetchAdapter';
 import { FileService } from '../services/FileService';
 import { UserService } from '../services/UserService';
 import { KeyService } from '../services/KeyService';
 import { CallbackService } from '../services/CallbackService';
 import { ReportService } from '../services/ReportService';
 import { PackageService } from '../services/PackageService';
 
-// Mock global fetch to prevent real requests during EQP construction
-vi.stubGlobal('fetch', vi.fn());
+vi.mock('../FetchAdapter', () => ({
+	FetchAdapter: vi.fn()
+}));
 
 describe('EQP', () => {
 	const defaultOptions = {
 		appId: 'test-app-id',
 		appSecret: 'test-app-secret'
 	};
 
+	beforeEach(() => {
+		vi.clearAllMocks();
+	});
+
 	describe('environment URLs', () => {
 		it('should use production URL by default', () => {
-			const eqp = new EQP(defaultOptions);
+			new EQP(defaultOptions);
 
-			expect(eqp).toBeDefined();
+			expect(FetchAdapter).toHaveBeenCalledWith('https://commercedeveloper-api.adobe.com/rest/v1');
 		});
 
 		it('should use production URL when environment is "production"', () => {
-			const eqp = new EQP({ ...defaultOptions, environment: 'production' });
+			new EQP({ ...defaultOptions, environment: 'production' });
 
-			expect(eqp).toBeDefined();
+			expect(FetchAdapter).toHaveBeenCalledWith('https://commercedeveloper-api.adobe.com/rest/v1');
 		});
 
 		it('should use sandbox URL when environment is "sandbox"', () => {
-			const eqp = new EQP({ ...defaultOptions, environment: 'sandbox' });
+			new EQP({ ...defaultOptions, environment: 'sandbox' });
 
-			expect(eqp).toBeDefined();
+			expect(FetchAdapter).toHaveBeenCalledWith('https://commercedeveloper-sandbox-api.adobe.com/rest/v1');
 		});
 	});
 
@@ -46,9 +52,9 @@ describe('EQP', () => {
 				delete: vi.fn()
 			};
 
-			const eqp = new EQP({ ...defaultOptions, adapter: customAdapter });
+			new EQP({ ...defaultOptions, adapter: customAdapter });
 
-			expect(eqp).toBeDefined();
+			expect(FetchAdapter).not.toHaveBeenCalled();
 		});
 	});
 

src/__tests__/services/CallbackService.test.ts

@@ -23,7 +23,7 @@ describe('CallbackService', () => {
 				updateUser: vi.fn().mockResolvedValue({ mage_id: 'MAG123' })
 			},
 			packageService: {
-				getPackageBySubmissionId: vi.fn().mockResolvedValue({ submission_id: 'sub-1' })
+				getPackageBySubmissionId: vi.fn().mockImplementation((id: string) => Promise.resolve({ submission_id: id }))
 			},
 			fileService: {
 				getFile: vi.fn().mockResolvedValue({
@@ -92,7 +92,7 @@ describe('CallbackService', () => {
 			expect(mockEqp.packageService.getPackageBySubmissionId).toHaveBeenCalledWith('sub-2');
 			expect(result).toEqual({
 				file: { file_upload_id: 'file-1', submission_ids: ['sub-1', 'sub-2'] },
-				submissions: [{ submission_id: 'sub-1' }, { submission_id: 'sub-1' }],
+				submissions: [{ submission_id: 'sub-1' }, { submission_id: 'sub-2' }],
 				result: 'pass'
 			});
 		});