fix: address PR review comments

- Restore console.error spies in cowriter.test.js to prevent leaks
- Fix misleading 'unicode escape' test (was valid JSON, now invalid)
- Add 256-char model name length limit to MODEL_NAME_PATTERN
- Add test case for model name exceeding length limit

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>

Author: CybotTM

Classes/Domain/DTO/CompleteRequest.php

@@ -30,7 +30,7 @@
      * Allowed characters in model names (alphanumeric, hyphens, underscores, dots, colons, slashes).
      * Examples: gpt-4o, claude-3-opus-20240229, mistral/mixtral-8x7b, openai:gpt-4.
      */
-    private const MODEL_NAME_PATTERN = '/^[a-zA-Z0-9][-a-zA-Z0-9_.:\/]*$/';
+    private const MODEL_NAME_PATTERN = '/^[a-zA-Z0-9][-a-zA-Z0-9_.:\/]{0,255}$/';
 
     /**
      * Maximum allowed prompt length in characters.

Tests/JavaScript/cowriter.test.js

@@ -290,14 +290,15 @@ describe('Cowriter Plugin', () => {
                 getItems: () => [{ data: 'prompt' }],
             };
             mockEditor.model.document.selection.getRanges.mockReturnValue([mockRange]);
-            vi.spyOn(console, 'error').mockImplementation(() => {});
+            const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
 
             await capturedButton.fire('execute');
 
             expect(mockEditor._writer.insert).toHaveBeenCalledWith(
                 expect.stringContaining('Unknown error'),
                 expect.anything()
             );
+            errorSpy.mockRestore();
         });
 
         it('should reset _isProcessing after completion', async () => {
@@ -316,10 +317,11 @@ describe('Cowriter Plugin', () => {
                 getItems: () => [{ data: 'prompt' }],
             };
             mockEditor.model.document.selection.getRanges.mockReturnValue([mockRange]);
-            vi.spyOn(console, 'error').mockImplementation(() => {});
+            const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
 
             await capturedButton.fire('execute');
             expect(plugin._isProcessing).toBe(false);
+            errorSpy.mockRestore();
         });
 
         it('should handle null insertPosition gracefully', async () => {

Tests/Unit/Domain/DTO/CompleteRequestFuzzTest.php

@@ -226,7 +226,7 @@ public static function malformedJsonProvider(): iterable
         yield 'empty object' => ['{}'];
         yield 'nested deeply' => [str_repeat('[', 100) . '1' . str_repeat(']', 100)];
         yield 'very large number' => ['{"prompt":"test","n":' . str_repeat('9', 1000) . '}'];
-        yield 'unicode escape' => ['{"prompt":"\\u0048\\u0065\\u006c\\u006c\\u006f"}'];
+        yield 'invalid unicode escape' => ['{"prompt":"\\u004G"}'];
     }
 
     // ===================================================
@@ -297,7 +297,8 @@ public static function modelOverrideEdgeCaseProvider(): iterable
         yield 'case sensitive prefix' => ['#CW:gpt-4o test', null, '#CW:gpt-4o test'];
         yield 'prefix mid-string' => ['hello #cw:gpt-4o test', null, 'hello #cw:gpt-4o test'];
         yield 'model with all valid chars' => ['#cw:a-b_c.d:e/f test', 'a-b_c.d:e/f', 'test'];
-        yield 'model max valid pattern' => ['#cw:' . str_repeat('a', 200) . ' test', str_repeat('a', 200), 'test'];
+        yield 'model max valid length' => ['#cw:' . str_repeat('a', 256) . ' test', str_repeat('a', 256), 'test'];
+        yield 'model name too long' => ['#cw:' . str_repeat('a', 257) . ' test', null, '#cw:' . str_repeat('a', 257) . ' test'];
     }
 
     // ===================================================