Review comment readability and linting

Author: FR4NK-W

config/config.go

@@ -64,10 +64,10 @@ type Config struct {
 	DNSSD           hinting.DNSHintGeneratorConf    `toml:"dnssd"`
 	MDNS            hinting.MDNSHintGeneratorConf   `toml:"mdns"`
 	Logging         LogConfig                       `toml:"log,omitempty"`
-	CryptoEngine	string                          `toml:"crypto_engine,omitempty"`
+	CryptoEngine    string                          `toml:"crypto_engine,omitempty"`
 }
 
-func (cfg Config) WorkingDir() string {
+func (cfg *Config) WorkingDir() string {
 	return filepath.Join(cfg.SciondConfigDir, "bootstrapper")
 }
 

config/sample.go

@@ -44,7 +44,7 @@ crypto_engine = "openssl"
     # Fixed hex string for the client DUID, no separators, no 0x prefix:
     #client_id = "0001000100000000deadbeefaabb"
 [ipv6]
-    # Whether to enable IPv6 Neighbor Discovery Protocol (NDP)
+    # Whether to enable IPv6 Neighbor Discovery Protocol (NDP) for the
     # Router Advertisement DNSSL and RDNS discovery or not (default false)
     enable = false
 [dnssd]

fetcher/crypto_cmds.go

@@ -6,7 +6,7 @@ import (
 )
 
 // Verify the signature of signedTopology
-// using the CA bundle rootCertsBundlePath, and outputs the verified payload to verifiedTopology.
+// using the CA bundle rootCertsBundlePath, and output the verified payload to verifiedTopology.
 func cmsVerifyOutput(ctx context.Context, signedTopology, rootCertsBundlePath, verifiedTopology string) (err error) {
 	if !ctx.Value("nativeCrypto").(bool) {
 		if err = checkExecutable("openssl"); err != nil {

fetcher/scion_cppki_verify.go

@@ -103,7 +103,7 @@ func setupVerifyEnv(cfg *config.Config) (ctx context.Context, cancel context.Can
 	// Signature verification should complete in a timely manner since it is a local operation
 	ctx, cancel = context.WithTimeout(context.Background(), verifyTimeout)
 
-	// check 'scion-pki' tool is on path and executable
+	// Check that 'scion-pki' tool is on path and executable
 	if err = checkExecutable("scion-pki"); err != nil {
 		return
 	}
@@ -122,7 +122,7 @@ func setupVerifyEnv(cfg *config.Config) (ctx context.Context, cancel context.Can
 	return
 }
 
-func checkExecutable(execName string) (err error){
+func checkExecutable(execName string) (err error) {
 	_, err = exec.LookPath(execName)
 	return
 }

hinting/dhcpv6.go

@@ -116,7 +116,7 @@ func getDuid(g *DHCPv6HintGenerator) (duid dhcpv6.Duid, err error) {
 		}
 	case duidEN, duidUUID:
 		// Not implemented
-		log.Error("Unsupported DUID type %s, set DUID directly as `client_id` " +
+		log.Error("Unsupported DUID type %s, set DUID directly as `client_id` "+
 			"or use the supported `DUID-LL` and `DUID-LLT`types.", "type", g.cfg.Duid)
 		err = fmt.Errorf("not implemented DUID type: %s", g.cfg.Duid)
 	default:

hinting/hinting.go

@@ -25,7 +25,7 @@ import (
 )
 
 const (
-	anapayaPEN = 55324 // Anapaya Systems Private Enterprise Number
+	anapayaPEN            = 55324 // Anapaya Systems Private Enterprise Number
 	DiscoveryPort  uint16 = 8041
 	DNSInfoTimeout        = 10 * time.Second
 )
@@ -205,7 +205,6 @@ func (m *MockHintGenerator) Generate(ipHintsChan chan<- net.TCPAddr) {
 	ipHintsChan <- *tcpAddr
 }
 
-
 func HasIPv6(iface *net.Interface) bool {
 	return len(ifaceIPv6Addrs(iface)) > 0
 }
@@ -225,7 +224,7 @@ func ifaceIPv6Addrs(iface *net.Interface) (ips []netip.Addr) {
 		}
 		ip, ok := netip.AddrFromSlice(ifaddr.IP)
 		// do not include IPv6 mapped IPv4 addresses and IPv6 loopback
-		if ok && ip.Is6() && !ip.Is4In6() && !ip.IsLoopback(){
+		if ok && ip.Is6() && !ip.Is4In6() && !ip.IsLoopback() {
 			ips = append(ips, ip)
 		}
 	}

res/packaging/debian/etc/scion/bootstrapper.toml

@@ -18,7 +18,7 @@ crypto_engine = "openssl"
     # Whether to enable DHCPv6 discovery or not (default false)
     enable = true
 [ipv6]
-    # Whether to enable IPv6 Neighbor Discovery Protocol (NDP)
+    # Whether to enable IPv6 Neighbor Discovery Protocol (NDP) for the
     # Router Advertisement DNSSL and RDNS discovery or not (default false)
     enable = true
 [dnssd]