Fix policy based filter operation in scionutils.policyConn (#169)

marcfrei · web-flow · commit 8bbf97bf3191 · 2020-11-11T11:04:24.000+01:00
The result of the policy based filter operation has been ignored in function queryPathsFiltered (policy_conn.go). There are currently no unit or integration tests for this.
diff --git a/ssh/scionutils/policy_conn.go b/ssh/scionutils/policy_conn.go
@@ -172,8 +172,7 @@ func queryPathsFiltered(ia addr.IA, policy *pathpol.Policy) ([]snet.Path, error)
 	for _, path := range paths {
 		pathSet[path.Fingerprint()] = path
 	}
-	policy.Filter(pathSet)
-	filterPathSlice(&paths, pathSet)
+	filterPathSlice(&paths, policy.Filter(pathSet))
 	return paths, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -172,8 +172,7 @@ func queryPathsFiltered(ia addr.IA, policy *pathpol.Policy) ([]snet.Path, error)`
`172`	`172`	`for _, path := range paths {`
`173`	`173`	`pathSet[path.Fingerprint()] = path`
`174`	`174`	`}`
`175`		`- policy.Filter(pathSet)`
`176`		`- filterPathSlice(&paths, pathSet)`
	`175`	`+ filterPathSlice(&paths, policy.Filter(pathSet))`
`177`	`176`	`return paths, nil`
`178`	`177`	`}`
`179`	`178`