Replace python2 with python3 in health-check scripts

Avoids dependency on python2 (which is not currently installed in VMs).

Author: matzf

webapp/dependencies.md

@@ -39,14 +39,13 @@ webapp \
 - curl
 - set
 - grep
-- python
+- python3
 - df
 - tr
 - free
 - sleep
 - cat
 - systemctl
-- python2
 
 ## SCION Binaries Used/Checked
 - $sbin/scmp

webapp/web/tests/health/netcheck.sh

@@ -10,11 +10,11 @@ as=$(echo ${iaFile} | cut -d"-" -f2)
 topologyFile=$SCION_GEN/ISD$isd/AS$as/endhost/topology.json
 
 # get remote addresses from interfaces
-ip_dsts=$(cat $topologyFile | python2 -c "import sys, json
+ip_dsts=$(cat $topologyFile | python3 -c "import sys, json
 brs = json.load(sys.stdin)['BorderRouters']
 for b in brs:
     for i in brs[b]['Interfaces']:
-        print brs[b]['Interfaces'][i]['RemoteOverlay']['Addr']")
+        print(brs[b]['Interfaces'][i]['RemoteOverlay']['Addr'])")
 
 # test icmp ping on each interface
 for ip_dst in $ip_dsts

webapp/web/tests/health/scmpcheck.sh

@@ -15,12 +15,12 @@ as=$(echo ${iaFile} | cut -d"-" -f2)
 topologyFile=$SCION_GEN/ISD$isd/AS$as/endhost/topology.json
 
 # get remote addresses from interfaces, return paired list
-dsts=($(cat $topologyFile | python2 -c "import sys, json
+dsts=($(cat $topologyFile | python3 -c "import sys, json
 brs = json.load(sys.stdin)['BorderRouters']
 for b in brs:
     for i in brs[b]['Interfaces']:
-        print brs[b]['Interfaces'][i]['ISD_AS']
-        print brs[b]['Interfaces'][i]['RemoteOverlay']['Addr']"))
+        print(brs[b]['Interfaces'][i]['ISD_AS'])
+        print(brs[b]['Interfaces'][i]['RemoteOverlay']['Addr'])"))
 
 # test scmp echo on each interface
 for ((i=0; i<${#dsts[@]}; i+=2))

webapp/web/tests/health/testVPN.sh

@@ -28,11 +28,11 @@ fi
 ipAddress=$(echo "$targetLines" | grep -oE "\b([0-9]{1,3}\.){3}[0-9]{1,3}\b" | head -n1)
 topologyFile=$SCION_GEN/ISD*/AS*/endhost/topology.json
 # ip address specified in the topology file. If "bind" parameter present, use that one; "public" if not
-ipTopology=$(cat $topologyFile | python2 -c "import sys, json
+ipTopology=$(cat $topologyFile | python3 -c "import sys, json
 brs = json.load(sys.stdin)['BorderRouters']
 interfaces=next(iter(brs.values()))['Interfaces']
 inter=next(iter(interfaces.values()))
-print inter['BindOverlay'] if 'BindOverlay' in inter.keys() else inter['PublicOverlay']['Addr']")
+print(inter['BindOverlay'] if 'BindOverlay' in inter.keys() else inter['PublicOverlay']['Addr'])")
 
 # 2.check if the ip address from the tun0 interface is consistent with the one from the topology.
 if [[ $ipAddress != $ipTopology ]]; then