Refactoring and fixes

Author: Tilmann Zäschke

CHANGELOG.md

@@ -22,6 +22,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
   [#13](https://github.com/netsec-ethz/scion-java-multiping/pull/13)
 - Fixed calculation of average and median values
   [#17](https://github.com/netsec-ethz/scion-java-multiping/pull/17)
+- Added proper tests, refactored PingAll and fixed minor issues
+  [#18](https://github.com/netsec-ethz/scion-java-multiping/pull/18)
 
 ## [0.4.0] - 2025-04-04
 

pom.xml

@@ -83,7 +83,7 @@
         <dependency>
             <groupId>org.scion</groupId>
             <artifactId>jpan</artifactId>
-            <version>0.6.0-SNAPSHOT</version>
+            <version>0.5.3</version>
         </dependency>
 
         <dependency>

src/main/java/org/scion/multiping/PingAll.java

@@ -312,24 +312,12 @@ private Scmp.TracerouteMessage findFastestTRasync(List<Path> paths, Ref<Path> re
         new ScmpSenderAsync.ResponseHandler() {
           @Override
           public void onResponse(Scmp.TimedMessage msg) {
-            System.out.println(
-                "Received response for "
-                    + ScionUtil.toStringIA(msg.getIdentifier())
-                    + " "
-                    + msg.getSequenceNumber());
             barrier.countDown();
             messages.put(msg.getIdentifier(), msg);
           }
 
           @Override
           public void onTimeout(Scmp.TimedMessage msg) {
-            System.out.println(
-                "Timeout for "
-                    + ScionUtil.toStringIA(msg.getIdentifier())
-                    + " "
-                    + msg.getSequenceNumber()
-                    + " "
-                    + msg.getPath().getRemoteAddress());
             barrier.countDown();
             messages.put(msg.getIdentifier(), msg);
           }
@@ -351,21 +339,18 @@ public void onException(Throwable t) {
     try (ScionProvider.Async sender = service.getAsync(handler)) {
       for (Path path : paths) {
         summary.incPathTried();
-        int x = sender.sendTracerouteLast(path);
-        System.out.println("Sending " + x + "     " + ScionUtil.toStringPath(path.getRawPath()) + " to " + path.getRemoteAddress());
+        sender.sendTracerouteLast(path);
       }
-    } catch (IOException e) {
-      println("ERROR: " + e.getMessage());
-      summary.incAsError();
-      return null;
-    }
 
-    // Wait for all messages to be received
-    try {
+      // Wait for all messages to be received, BEFORE closing the "sender".
       if (!barrier.await(1100, TimeUnit.MILLISECONDS)) {
         throw new IllegalStateException(
             "Missing messages: " + barrier.getCount() + "/" + paths.size());
       }
+    } catch (IOException e) {
+      println("ERROR: " + e.getMessage());
+      summary.incAsError();
+      return null;
     } catch (InterruptedException e) {
       Thread.currentThread().interrupt();
       throw new IllegalStateException(e);