Component::redirect() first parameter $code is deprecated (BC break)

Author: dg

src/Application/UI/Component.php

@@ -314,20 +314,21 @@ public function isLinkCurrent(string $destination = NULL, $args = []): bool
 
 	/**
 	 * Redirect to another presenter, action or signal.
-	 * @param  int      [optional] HTTP error code
 	 * @param  string   destination in format "[//] [[[module:]presenter:]action | signal! | this] [#fragment]"
 	 * @param  array|mixed
 	 * @throws Nette\Application\AbortException
 	 */
 	public function redirect($code, $destination = NULL, $args = []): void
 	{
-		if (!is_numeric($code)) { // first parameter is optional
+		if (is_numeric($code)) {
+			trigger_error(__METHOD__ . '() first parameter $code is deprecated; use redirectPermanent() for 301 redirect.', E_USER_DEPRECATED);
+			if (func_num_args() > 3 || !is_array($args)) {
+				$args = array_slice(func_get_args(), 2);
+			}
+		} elseif (!is_numeric($code)) { // first parameter is optional
 			$args = func_num_args() < 3 && is_array($destination) ? $destination : array_slice(func_get_args(), 1);
 			$destination = $code;
 			$code = NULL;
-
-		} elseif (func_num_args() > 3 || !is_array($args)) {
-			$args = array_slice(func_get_args(), 2);
 		}
 
 		$presenter = $this->getPresenter();

tests/UI/Component.redirect().phpt

@@ -65,15 +65,15 @@ test(function () use ($presenter) {
 
 
 test(function () use ($presenter) {
-	$presenter->redirect(301, 'foo', ['arg' => 1]);
+	@$presenter->redirect(301, 'foo', ['arg' => 1]); // @ is deprecated
 	Assert::type(Nette\Application\Responses\RedirectResponse::class, $presenter->response);
 	Assert::same(301, $presenter->response->getCode());
 	Assert::same('http://localhost/?arg=1&action=foo&presenter=test', $presenter->response->getUrl());
 });
 
 
 test(function () use ($presenter) {
-	$presenter->redirect(301, 'foo', 2);
+	@$presenter->redirect(301, 'foo', 2); // @ is deprecated
 	Assert::type(Nette\Application\Responses\RedirectResponse::class, $presenter->response);
 	Assert::same(301, $presenter->response->getCode());
 	Assert::same('http://localhost/?val=2&action=foo&presenter=test', $presenter->response->getUrl());