PresenterComponentReflection::parseAnnotation() recognizes TRUE / FALSE / NULL

Author: dg

src/Application/UI/PresenterComponentReflection.php

@@ -199,10 +199,12 @@ public static function parseAnnotation(\Reflector $ref, $name)
 		if (!preg_match_all("#[\\s*]@$name(?:\(\\s*([^)]*)\\s*\))?#", $ref->getDocComment(), $m)) {
 			return FALSE;
 		}
+		static $tokens = ['true' => TRUE, 'false' => FALSE, 'null' => NULL];
 		$res = [];
 		foreach ($m[1] as $s) {
-			$arr = $s === '' ? [TRUE] : preg_split('#\s*,\s*#', $s, -1, PREG_SPLIT_NO_EMPTY);
-			$res = array_merge($res, $arr);
+			foreach (preg_split('#\s*,\s*#', $s, -1, PREG_SPLIT_NO_EMPTY) ?: ['true'] as $item) {
+				$res[] = array_key_exists($tmp = strtolower($item), $tokens) ? $tokens[$tmp] : $item;
+			}
 		}
 		return $res;
 	}

tests/UI/PresenterComponentReflection.parseAnnotation.phpt

@@ -30,6 +30,6 @@ $rc = new ReflectionClass('TestClass');
 
 Assert::same(['value ="Johno\'s addendum"', 'mode=True', TRUE, TRUE], Reflection::parseAnnotation($rc, 'title'));
 Assert::same(['item 1'], Reflection::parseAnnotation($rc, 'components'));
-Assert::same(['true', 'FALSE', 'null'], Reflection::parseAnnotation($rc, 'persistent'));
+Assert::same([TRUE, FALSE, NULL], Reflection::parseAnnotation($rc, 'persistent'));
 Assert::same([TRUE], Reflection::parseAnnotation($rc, 'renderable'));
 Assert::false(Reflection::parseAnnotation($rc, 'missing'));