SimpleRouter: support for parameter 'module' is deprecated (BC break)

dg · dg · commit ac454ca8d681 · 2019-03-09T18:07:22.000+01:00
diff --git a/src/Application/Routers/SimpleRouter.php b/src/Application/Routers/SimpleRouter.php
@@ -43,6 +43,7 @@ public function __construct($defaults = [], int $flags = 0)
 		}
 
 		if (isset($defaults[self::MODULE_KEY])) {
+			trigger_error(__METHOD__ . '() parameter module is deprecated, use RouteList::withModule() instead.', E_USER_DEPRECATED);
 			$this->module = $defaults[self::MODULE_KEY] . ':';
 			unset($defaults[self::MODULE_KEY]);
 		}
diff --git a/tests/Routers/SimpleRouter.module.phpt b/tests/Routers/SimpleRouter.module.phpt
@@ -14,7 +14,7 @@ use Tester\Assert;
 require __DIR__ . '/../bootstrap.php';
 
 
-$router = new Application\Routers\SimpleRouter([
+$router = @new Application\Routers\SimpleRouter([ // @ is deprecated
 	'module' => 'main:sub',
 ]);
 

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ public function __construct($defaults = [], int $flags = 0)`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`if (isset($defaults[self::MODULE_KEY])) {`
	`46`	`+ trigger_error(__METHOD__ . '() parameter module is deprecated, use RouteList::withModule() instead.', E_USER_DEPRECATED);`
`46`	`47`	`$this->module = $defaults[self::MODULE_KEY] . ':';`
`47`	`48`	`unset($defaults[self::MODULE_KEY]);`
`48`	`49`	`}`