Skip to content

Commit be979b7

Browse files
committed
added PHPStan baseline
1 parent 59df327 commit be979b7

File tree

4 files changed

+51
-1
lines changed

4 files changed

+51
-1
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"require-dev": {
2222
"nette/tester": "^2.5",
2323
"tracy/tracy": "^2.9",
24-
"phpstan/phpstan-nette": "^2.0@stable"
24+
"phpstan/phpstan": "^2.0@stable"
2525
},
2626
"autoload": {
2727
"classmap": ["src/"],

phpstan-baseline.neon

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
parameters:
2+
ignoreErrors:
3+
-
4+
message: '#^Property Nette\\ComponentModel\\Component\:\:\$monitors \(array\<''''\|class\-string\<Nette\\ComponentModel\\IComponent\>, array\{Nette\\ComponentModel\\IComponent\|null, int\|null, string\|null, array\{list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>, list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>\}\|null\}\>\) does not accept array\<''''\|class\-string\<Nette\\ComponentModel\\IComponent\>, array\{3\: array\{list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>, list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>\}\}\|array\{Nette\\ComponentModel\\IComponent\|null, int\|null, string\|null, array\{list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>, list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>\}\|null\}\>\.$#'
5+
identifier: assign.propertyType
6+
count: 2
7+
path: src/ComponentModel/Component.php
8+
9+
-
10+
message: '#^Property Nette\\ComponentModel\\Component\:\:\$monitors \(array\<''''\|class\-string\<Nette\\ComponentModel\\IComponent\>, array\{Nette\\ComponentModel\\IComponent\|null, int\|null, string\|null, array\{list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>, list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>\}\|null\}\>\) does not accept non\-empty\-array\<''''\|class\-string\<Nette\\ComponentModel\\IComponent\>, array\{3\: array\{list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>, list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>\}\}\|array\{Nette\\ComponentModel\\IComponent\|null, int\|null, string\|null, array\{list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>, list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>\}\|null\}\>\.$#'
11+
identifier: assign.propertyType
12+
count: 1
13+
path: src/ComponentModel/Component.php
14+
15+
-
16+
message: '#^Property Nette\\ComponentModel\\Component\:\:\$monitors \(array\<''''\|class\-string\<Nette\\ComponentModel\\IComponent\>, array\{Nette\\ComponentModel\\IComponent\|null, int\|null, string\|null, array\{list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>, list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>\}\|null\}\>\) does not accept non\-empty\-array\<''''\|class\-string\<Nette\\ComponentModel\\IComponent\>, array\{3\: array\{list\<Closure\(T\)\: void\>, non\-empty\-list\<Closure\(T\)\: void\>\}\}\|array\{Nette\\ComponentModel\\IComponent\|null, int\|null, string\|null, array\{list\<Closure\(T\)\: void\>, list\<Closure\(T\)\: void\>\}\|null\}\>\.$#'
17+
identifier: assign.propertyType
18+
count: 1
19+
path: src/ComponentModel/Component.php
20+
21+
-
22+
message: '#^Property Nette\\ComponentModel\\Component\:\:\$monitors \(array\<''''\|class\-string\<Nette\\ComponentModel\\IComponent\>, array\{Nette\\ComponentModel\\IComponent\|null, int\|null, string\|null, array\{list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>, list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>\}\|null\}\>\) does not accept non\-empty\-array\<''''\|class\-string\<Nette\\ComponentModel\\IComponent\>, array\{3\: array\{non\-empty\-list\<Closure\(T\)\: void\>, list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>\}\}\|array\{Nette\\ComponentModel\\IComponent\|null, int\|null, string\|null, array\{list\<Closure\(T\)\: void\>, list\<Closure\(Nette\\ComponentModel\\IComponent\)\: void\>\}\|null\}\>\.$#'
23+
identifier: assign.propertyType
24+
count: 1
25+
path: src/ComponentModel/Component.php
26+
27+
-
28+
message: '#^Method Nette\\ComponentModel\\Container\:\:getComponents\(\) should return array\<int\|string, Nette\\ComponentModel\\IComponent\> but returns CallbackFilterIterator\<mixed, mixed, RecursiveIteratorIterator\<Nette\\ComponentModel\\RecursiveComponentIterator\>\>\|RecursiveIteratorIterator\<Nette\\ComponentModel\\RecursiveComponentIterator\>\.$#'
29+
identifier: return.type
30+
count: 1
31+
path: src/ComponentModel/Container.php
32+
33+
-
34+
message: '#^Method Nette\\ComponentModel\\IContainer\:\:getComponent\(\) invoked with 2 parameters, 1 required\.$#'
35+
identifier: arguments.count
36+
count: 1
37+
path: src/ComponentModel/Container.php
38+
39+
-
40+
message: '#^Call to an undefined method Nette\\ComponentModel\\IComponent\:\:getComponents\(\)\.$#'
41+
identifier: method.notFound
42+
count: 1
43+
path: src/ComponentModel/RecursiveComponentIterator.php

phpstan.neon

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,8 @@ parameters:
44
paths:
55
- src
66
- tests/types
7+
8+
checkMissingCallableSignature: true
9+
10+
includes:
11+
- phpstan-baseline.neon

src/ComponentModel/Component.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ private function refreshMonitors(int $depth, ?array &$missing = null, array &$li
242242
if ($missing === null) { // detaching
243243
foreach ($this->monitors as $type => [$ancestor, $inDepth, , $callbacks]) {
244244
if (isset($inDepth) && $inDepth > $depth) { // only process if ancestor was deeper than current detachment point
245+
assert($ancestor !== null);
245246
if ($callbacks) {
246247
$this->monitors[$type] = [null, null, null, $callbacks]; // clear cached object, keep listener registrations
247248
foreach ($callbacks[1] as $detached) {
@@ -265,6 +266,7 @@ private function refreshMonitors(int $depth, ?array &$missing = null, array &$li
265266

266267
} else { // need to check if ancestor exists
267268
unset($this->monitors[$type]); // force fresh lookup
269+
assert($type !== '');
268270
if ($ancestor = $this->lookup($type, throw: false)) {
269271
foreach ($callbacks[0] as $attached) {
270272
$listeners[] = [$attached, $ancestor];

0 commit comments

Comments
 (0)