ConnectionPanel: bypasses SqlPreprocessor for explain to avoid double processing [Closes #259]

dg · dg · commit 1f457f6ccfbf · 2020-07-10T18:29:37.000+02:00
diff --git a/src/Bridges/DatabaseTracy/ConnectionPanel.php b/src/Bridges/DatabaseTracy/ConnectionPanel.php
@@ -112,7 +112,6 @@ public function getTab(): string
 
 	public function getPanel(): ?string
 	{
-		$this->disabled = true;
 		if (!$this->count) {
 			return null;
 		}
@@ -125,7 +124,7 @@ public function getPanel(): ?string
 			if (!$error && $this->explain && $command === 'select') {
 				try {
 					$cmd = is_string($this->explain) ? $this->explain : 'EXPLAIN';
-					$explain = $connection->queryArgs("$cmd $sql", $params)->fetchAll();
+					$explain = (new Nette\Database\ResultSet($connection, "$cmd $sql", $params))->fetchAll();
 				} catch (\PDOException $e) {
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,6 @@ public function getTab(): string`
`112`	`112`
`113`	`113`	`public function getPanel(): ?string`
`114`	`114`	`{`
`115`		`- $this->disabled = true;`
`116`	`115`	`if (!$this->count) {`
`117`	`116`	`return null;`
`118`	`117`	`}`
`@@ -125,7 +124,7 @@ public function getPanel(): ?string`
`125`	`124`	`if (!$error && $this->explain && $command === 'select') {`
`126`	`125`	`try {`
`127`	`126`	`$cmd = is_string($this->explain) ? $this->explain : 'EXPLAIN';`
`128`		`- $explain = $connection->queryArgs("$cmd $sql", $params)->fetchAll();`
	`127`	`+ $explain = (new Nette\Database\ResultSet($connection, "$cmd $sql", $params))->fetchAll();`
`129`	`128`	`} catch (\PDOException $e) {`
`130`	`129`	`}`
`131`	`130`	`}`