Selection::insert(): multi insert returns number of affected rows instead of data (BC break)

Author: Unlink

src/Database/Table/Selection.php

@@ -744,7 +744,7 @@ public function getDataRefreshed()
 	/**
 	 * Inserts row in a table.
 	 * @param  array|\Traversable|Selection array($column => $value)|\Traversable|Selection for INSERT ... SELECT
-	 * @return IRow|int|bool Returns IRow or number of affected rows for Selection or table without primary key
+	 * @return IRow|int|bool Returns IRow or number of affected rows for Selection, multi insert or table without primary key
 	 */
 	public function insert($data)
 	{
@@ -766,7 +766,7 @@ public function insert($data)
 		}
 
 		if (Nette\Utils\Arrays::isList($data)) {
-			return $data;
+			return $return->getRowCount();
 		}
 
 		$primaryKey = [];

tests/Database/Table/Selection.insert().multi.phpt

@@ -14,7 +14,7 @@ Nette\Database\Helpers::loadFromFile($connection, __DIR__ . "/../files/{$driverN
 
 test(function () use ($context) {
 	Assert::same(3, $context->table('author')->count());
-	$context->table('author')->insert([
+	$insert = $context->table('author')->insert([
 		[
 			'name' => 'Catelyn Stark',
 			'web' => 'http://example.com',
@@ -26,15 +26,17 @@ test(function () use ($context) {
 			'born' => new DateTime('2021-11-11'),
 		],
 	]);  // INSERT INTO `author` (`name`, `web`, `born`) VALUES ('Catelyn Stark', 'http://example.com', '2011-11-11 00:00:00'), ('Sansa Stark', 'http://example.com', '2021-11-11 00:00:00')
+	Assert::same(2, $insert);
 	Assert::same(5, $context->table('author')->count());
 
 	$context->table('book_tag')->where('book_id', 1)->delete();  // DELETE FROM `book_tag` WHERE (`book_id` = ?)
 
 	Assert::same(4, $context->table('book_tag')->count());
-	$context->table('book')->get(1)->related('book_tag')->insert([  // SELECT * FROM `book` WHERE (`id` = ?)
+	$insert = $context->table('book')->get(1)->related('book_tag')->insert([  // SELECT * FROM `book` WHERE (`id` = ?)
 		['tag_id' => 21],
 		['tag_id' => 22],
 		['tag_id' => 23],
 	]);  // INSERT INTO `book_tag` (`tag_id`, `book_id`) VALUES (21, 1), (22, 1), (23, 1)
+	Assert::same(3, $insert);
 	Assert::same(7, $context->table('book_tag')->count());
 });