Skip to content

Commit 52e8d59

Browse files
committed
added PHP 7.1 scalar and return type hints
1 parent 1adcc20 commit 52e8d59

37 files changed

+376
-744
lines changed

src/Bridges/DatabaseDI/DatabaseExtension.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class DatabaseExtension extends Nette\DI\CompilerExtension
3333
private $debugMode;
3434

3535

36-
public function __construct($debugMode = FALSE)
36+
public function __construct(bool $debugMode = FALSE)
3737
{
3838
$this->debugMode = $debugMode;
3939
}
@@ -62,7 +62,7 @@ public function loadConfiguration()
6262
}
6363

6464

65-
private function setupDatabase($config, $name)
65+
private function setupDatabase($config, $name): void
6666
{
6767
$builder = $this->getContainerBuilder();
6868

src/Bridges/DatabaseTracy/ConnectionPanel.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function __construct(Nette\Database\Connection $connection)
4949
}
5050

5151

52-
public function logQuery(Nette\Database\Connection $connection, $result)
52+
public function logQuery(Nette\Database\Connection $connection, $result): void
5353
{
5454
if ($this->disabled) {
5555
return;
@@ -81,10 +81,10 @@ public function logQuery(Nette\Database\Connection $connection, $result)
8181
}
8282

8383

84-
public static function renderException($e)
84+
public static function renderException($e): ?array
8585
{
8686
if (!$e instanceof \PDOException) {
87-
return;
87+
return NULL;
8888
}
8989
if (isset($e->queryString)) {
9090
$sql = $e->queryString;
@@ -99,7 +99,7 @@ public static function renderException($e)
9999
}
100100

101101

102-
public function getTab()
102+
public function getTab(): string
103103
{
104104
$name = $this->name;
105105
$count = $this->count;
@@ -110,11 +110,11 @@ public function getTab()
110110
}
111111

112112

113-
public function getPanel()
113+
public function getPanel(): ?string
114114
{
115115
$this->disabled = TRUE;
116116
if (!$this->count) {
117-
return;
117+
return NULL;
118118
}
119119

120120
$name = $this->name;

src/Database/Connection.php

Lines changed: 19 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@ public function __construct($dsn, $user = NULL, $password = NULL, array $options
5454
}
5555

5656

57-
/** @return void */
58-
public function connect()
57+
public function connect(): void
5958
{
6059
if ($this->pdo) {
6160
return;
@@ -78,38 +77,33 @@ public function connect()
7877
}
7978

8079

81-
/** @return void */
82-
public function reconnect()
80+
public function reconnect(): void
8381
{
8482
$this->disconnect();
8583
$this->connect();
8684
}
8785

8886

89-
/** @return void */
90-
public function disconnect()
87+
public function disconnect(): void
9188
{
9289
$this->pdo = NULL;
9390
}
9491

9592

96-
/** @return string */
97-
public function getDsn()
93+
public function getDsn(): string
9894
{
9995
return $this->params[0];
10096
}
10197

10298

103-
/** @return PDO */
104-
public function getPdo()
99+
public function getPdo(): PDO
105100
{
106101
$this->connect();
107102
return $this->pdo;
108103
}
109104

110105

111-
/** @return ISupplementalDriver */
112-
public function getSupplementalDriver()
106+
public function getSupplementalDriver(): ISupplementalDriver
113107
{
114108
$this->connect();
115109
return $this->driver;
@@ -118,9 +112,8 @@ public function getSupplementalDriver()
118112

119113
/**
120114
* @param string sequence object
121-
* @return string
122115
*/
123-
public function getInsertId($name = NULL)
116+
public function getInsertId(string $name = NULL): string
124117
{
125118
try {
126119
$res = $this->getPdo()->lastInsertId($name);
@@ -134,9 +127,8 @@ public function getInsertId($name = NULL)
134127
/**
135128
* @param string string to be quoted
136129
* @param int data type hint
137-
* @return string
138130
*/
139-
public function quote($string, $type = PDO::PARAM_STR)
131+
public function quote(string $string, int $type = PDO::PARAM_STR): string
140132
{
141133
try {
142134
return $this->getPdo()->quote($string, $type);
@@ -146,33 +138,28 @@ public function quote($string, $type = PDO::PARAM_STR)
146138
}
147139

148140

149-
/** @return void */
150-
function beginTransaction()
141+
function beginTransaction(): void
151142
{
152143
$this->query('::beginTransaction');
153144
}
154145

155146

156-
/** @return void */
157-
function commit()
147+
function commit(): void
158148
{
159149
$this->query('::commit');
160150
}
161151

162152

163-
/** @return void */
164-
public function rollBack()
153+
public function rollBack(): void
165154
{
166155
$this->query('::rollBack');
167156
}
168157

169158

170159
/**
171160
* Generates and executes SQL query.
172-
* @param string
173-
* @return ResultSet
174161
*/
175-
public function query($sql, ...$params)
162+
public function query(string $sql, ...$params): ResultSet
176163
{
177164
[$sql, $params] = $this->preprocess($sql, ...$params);
178165
try {
@@ -186,11 +173,7 @@ public function query($sql, ...$params)
186173
}
187174

188175

189-
/**
190-
* @param string
191-
* @return ResultSet
192-
*/
193-
public function queryArgs($sql, array $params)
176+
public function queryArgs(string $sql, array $params): ResultSet
194177
{
195178
return $this->query($sql, ...$params);
196179
}
@@ -199,7 +182,7 @@ public function queryArgs($sql, array $params)
199182
/**
200183
* @return [string, array]
201184
*/
202-
public function preprocess($sql, ...$params)
185+
public function preprocess($sql, ...$params): array
203186
{
204187
$this->connect();
205188
return $params
@@ -213,52 +196,42 @@ public function preprocess($sql, ...$params)
213196

214197
/**
215198
* Shortcut for query()->fetch()
216-
* @param string
217-
* @return Row|NULL
218199
*/
219-
public function fetch($sql, ...$params)
200+
public function fetch(string $sql, ...$params): ?Row
220201
{
221202
return $this->query($sql, ...$params)->fetch();
222203
}
223204

224205

225206
/**
226207
* Shortcut for query()->fetchField()
227-
* @param string
228208
* @return mixed
229209
*/
230-
public function fetchField($sql, ...$params)
210+
public function fetchField(string $sql, ...$params)
231211
{
232212
return $this->query($sql, ...$params)->fetchField();
233213
}
234214

235215

236216
/**
237217
* Shortcut for query()->fetchPairs()
238-
* @param string
239-
* @return array
240218
*/
241-
public function fetchPairs($sql, ...$params)
219+
public function fetchPairs(string $sql, ...$params): array
242220
{
243221
return $this->query($sql, ...$params)->fetchPairs();
244222
}
245223

246224

247225
/**
248226
* Shortcut for query()->fetchAll()
249-
* @param string
250-
* @return array
251227
*/
252-
public function fetchAll($sql, ...$params)
228+
public function fetchAll(string $sql, ...$params): array
253229
{
254230
return $this->query($sql, ...$params)->fetchAll();
255231
}
256232

257233

258-
/**
259-
* @return SqlLiteral
260-
*/
261-
public static function literal($value, ...$params)
234+
public static function literal($value, ...$params): SqlLiteral
262235
{
263236
return new SqlLiteral($value, $params);
264237
}

0 commit comments

Comments
 (0)