Merge pull request #82 from Unlink/zero-pk-fix

Selection: fixed bug with zero in primary key

Author: dg

src/Database/Table/Selection.php

@@ -506,8 +506,8 @@ protected function execute()
 		foreach ($result->getPdoStatement() as $key => $row) {
 			$row = $this->createRow($result->normalizeRow($row));
 			$primary = $row->getSignature(FALSE);
-			$usedPrimary = $usedPrimary && $primary;
-			$this->rows[$primary ?: $key] = $row;
+			$usedPrimary = $usedPrimary && (string) $primary !== '';
+			$this->rows[$usedPrimary ? $primary : $key] = $row;
 		}
 		$this->data = $this->rows;
 

tests/Database/Table/bugs/ZeroPrimaryKey.phpt

@@ -0,0 +1,36 @@
+<?php
+
+/**
+ * Test: Zero Primary key bug
+ * @dataProvider? ../../databases.ini mysql
+ */
+
+use Tester\Assert;
+
+require __DIR__ . '/../../connect.inc.php';
+
+$context->query('CREATE DATABASE IF NOT EXISTS nette_test');
+$context->query('USE nette_test');
+
+$context->query('
+	CREATE TABLE ships (
+		id INTEGER PRIMARY KEY NOT NULL,
+		name TEXT NOT NULL
+	);
+');
+
+$context->query('
+	INSERT INTO ships (id, name) VALUES(2, "Enterprise");
+');
+
+$context->query('
+	INSERT INTO ships (id, name) VALUES(0, "Endeavour");
+');
+
+Assert::same(2, $context->table('ships')->order('id DESC')->count());
+
+$result = $context->table('ships')->order('id DESC')->fetchAll(); // SELECT * FROM `ships` ORDER BY id DESC
+
+Assert::same("Enterprise", $result[2]->name);
+
+Assert::same("Endeavour", $result[0]->name);