Container: optimized getService() performance

JanTvrdik · dg · commit 43c60cd9ff6f · 2015-02-06T00:38:05.000+01:00
diff --git a/src/DI/Container.php b/src/DI/Container.php
@@ -98,8 +98,10 @@ public function removeService($name)
 	 */
 	public function getService($name)
 	{
-		$name = isset($this->meta[self::ALIASES][$name]) ? $this->meta[self::ALIASES][$name] : $name;
 		if (!isset($this->registry[$name])) {
+			if (isset($this->meta[self::ALIASES][$name])) {
+				return $this->getService($this->meta[self::ALIASES][$name]);
+			}
 			$this->registry[$name] = $this->createService($name);
 		}
 		return $this->registry[$name];

Original file line number	Diff line number	Diff line change
`@@ -98,8 +98,10 @@ public function removeService($name)`
`98`	`98`	`*/`
`99`	`99`	`public function getService($name)`
`100`	`100`	`{`
`101`		`- $name = isset($this->meta[self::ALIASES][$name]) ? $this->meta[self::ALIASES][$name] : $name;`
`102`	`101`	`if (!isset($this->registry[$name])) {`
	`102`	`+ if (isset($this->meta[self::ALIASES][$name])) {`
	`103`	`+ return $this->getService($this->meta[self::ALIASES][$name]);`
	`104`	`+ }`
`103`	`105`	`$this->registry[$name] = $this->createService($name);`
`104`	`106`	`}`
`105`	`107`	`return $this->registry[$name];`