ServiceDefinition: deprecated parameters (BC break)

Author: dg

src/DI/Config/Processor.php

@@ -32,7 +32,6 @@ class Processor
 				'factory' => 'callable|Nette\DI\Definitions\Statement',
 				'arguments' => 'array',
 				'setup' => 'list',
-				'parameters' => 'array',
 				'inject' => 'bool',
 				'autowired' => 'bool|string|array',
 				'tags' => 'array',
@@ -225,10 +224,6 @@ private function updateServiceDefinition(Definitions\ServiceDefinition $definiti
 			}
 		}
 
-		if (isset($config['parameters'])) {
-			$definition->setParameters($config['parameters']);
-		}
-
 		if (isset($config['inject'])) {
 			$definition->addTag(Extensions\InjectExtension::TAG_INJECT, $config['inject']);
 		}

src/DI/Definitions/ServiceDefinition.php

@@ -24,9 +24,6 @@
  */
 final class ServiceDefinition extends Definition
 {
-	/** @var array */
-	public $parameters = [];
-
 	/** @var Statement|null */
 	private $factory;
 
@@ -135,18 +132,21 @@ public function addSetup($entity, array $args = [])
 
 
 	/**
-	 * @return static
+	 * @deprecated
 	 */
 	public function setParameters(array $params)
 	{
-		$this->parameters = $params;
-		return $this;
+		throw new Nette\DeprecatedException(sprintf('Service %s: %s() is deprecated.', $this->getName(), __METHOD__));
 	}
 
 
+	/**
+	 * @deprecated
+	 */
 	public function getParameters(): array
 	{
-		return $this->parameters;
+		trigger_error(sprintf('Service %s: %s() is deprecated.', $this->getName(), __METHOD__), E_USER_DEPRECATED);
+		return [];
 	}
 
 
@@ -224,8 +224,6 @@ public function complete(Nette\DI\Resolver $resolver): void
 
 	public function generateMethod(Nette\PhpGenerator\Method $method, Nette\DI\PhpGenerator $generator): void
 	{
-		$method->setParameters($generator->convertParameters($this->parameters));
-
 		$entity = $this->getFactory()->getEntity();
 		$code = '$service = ' . $generator->formatStatement($this->getFactory()) . ";\n";
 		$type = $this->getType();

src/DI/Resolver.php

@@ -186,12 +186,6 @@ public function completeStatement(Statement $statement, bool $currentServiceAllo
 				break;
 
 			case $entity instanceof Reference:
-				$params = [];
-				foreach ($this->resolveReference($entity)->parameters as $k => $v) {
-					$params[] = preg_replace('#\w+\z#', '\$$0', (is_int($k) ? $v : $k)) . (is_int($k) ? '' : ' = ' . PhpHelpers::dump($v));
-				}
-				$rm = new \ReflectionFunction(eval('return function(' . implode(', ', $params) . ') {};'));
-				$arguments = $this->autowireArguments($rm, $arguments);
 				break;
 
 			case is_array($entity):