Skip to content

Commit 640f1a2

Browse files
committed
CompilerExtension: uses $this->config only when parameter is not passed
1 parent 9799449 commit 640f1a2

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/DI/CompilerExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ public function afterCompile(Nette\PhpGenerator\ClassType $class)
125125
*/
126126
protected function validateConfig(array $expected, array $config = NULL, $name = NULL)
127127
{
128-
if ($extra = array_diff_key((array) $config ?: $this->config, $expected)) {
128+
if ($extra = array_diff_key(func_num_args() > 1 ? (array) $config : $this->config, $expected)) {
129129
$name = $name ?: $this->name;
130130
$extra = implode(", $name.", array_keys($extra));
131131
throw new Nette\InvalidStateException("Unknown configuration option $name.$extra.");

tests/DI/CompilerExtension.validateConfig.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,6 @@ Assert::exception(function() {
3838
Assert::exception(function() {
3939
Assert::with(new MyExtension, function() {
4040
$this->setConfig(array('c' => TRUE, 'd' => TRUE));
41-
$this->validateConfig(array('a' => TRUE, 'b' => TRUE), NULL, 'name');
41+
$this->validateConfig(array('a' => TRUE, 'b' => TRUE));
4242
});
43-
}, 'Nette\InvalidStateException', 'Unknown configuration option name.c, name.d.');
43+
}, 'Nette\InvalidStateException', 'Unknown configuration option my.c, my.d.');

0 commit comments

Comments
 (0)