ContainerBuilder: warns when autowired service type is unknown (BC break)

Author: dg

src/DI/ContainerBuilder.php

@@ -348,6 +348,9 @@ private function resolveServiceClass($name, $recursive = array())
 				throw new ServiceCreationException("Class or interface $def->class used in service '$name' not found.");
 			}
 			$def->class = Reflection\ClassType::from($def->class)->getName();
+
+		} elseif ($def->autowired) {
+			trigger_error("Type of service '$name' is unknown.", E_USER_NOTICE);
 		}
 		return $def->class;
 	}

tests/DI/Compiler.extensionOverride.phpt

@@ -13,6 +13,7 @@ require __DIR__ . '/../bootstrap.php';
 
 class Factory
 {
+	/** @return Lorem */
 	static function createLorem($arg = NULL)
 	{
 		return new Lorem($arg);
@@ -22,6 +23,7 @@ class Factory
 
 class IpsumFactory
 {
+	/** @return Ipsum */
 	static function create($arg = NULL)
 	{
 		return new Ipsum($arg);

tests/DI/Compiler.services.factory.phpt

@@ -13,6 +13,7 @@ require __DIR__ . '/../bootstrap.php';
 
 class Factory
 {
+	/** @return Lorem */
 	static function createLorem($arg)
 	{
 		return new Lorem(__METHOD__ . ' ' . $arg);
@@ -32,6 +33,7 @@ class Lorem
 		$this->arg = $arg;
 	}
 
+	/** @return Lorem */
 	function foo()
 	{
 		$this->foo = func_get_args();

tests/DI/ContainerBuilder.basic.phpt

@@ -15,6 +15,7 @@ class Service
 {
 	public $methods;
 
+	/** @return Service */
 	static function create(DI\Container $container = NULL)
 	{
 		return new self(array_slice(func_get_args(), 1));

tests/DI/ContainerBuilder.basic2.phpt

@@ -16,6 +16,7 @@ class Factory
 	private function __construct()
 	{}
 
+	/** @return Factory */
 	static function create()
 	{
 		return new self;

tests/DI/ContainerBuilder.factory.error.phpt

@@ -119,3 +119,16 @@ Assert::exception(function() {
 	$builder->addDefinition('one')->setFactory('Bad6::create');
 	$builder->generateClasses();
 }, 'Nette\InvalidStateException', "Factory 'Bad6::create' used in service 'one' is not callable.");
+
+
+class Bad7
+{
+	static function create()
+	{}
+}
+
+Assert::error(function() {
+	$builder = new DI\ContainerBuilder;
+	$builder->addDefinition('one')->setFactory('Bad7::create');
+	$builder->generateClasses();
+}, E_USER_NOTICE, "Type of service 'one' is unknown.");

tests/DI/files/compiler.services.factory.neon

@@ -54,4 +54,6 @@ services:
 
 	rich5: Factory()(1)
 
-	rich6: Factory::getClass(1)(1)
+	rich6:
+		factory: Factory::getClass(1)(1)
+		class: Lorem