Validator::validateNumeric() accepts unsigned integer [Closes #246]

Author: dg

src/Forms/Validator.php

@@ -284,7 +284,9 @@ public static function validatePatternCaseInsensitive(IControl $control, string
 	 */
 	public static function validateNumeric(IControl $control): bool
 	{
-		return (bool) Strings::match($control->getValue(), '#^\d+$#D');
+		$value = $control->getValue();
+		return (is_int($value) && $value >= 0)
+			|| (is_string($value) && Strings::match($value, '#^\d+$#D'));
 	}
 
 

tests/Forms/Controls.TestBase.validators.phpt

@@ -165,15 +165,25 @@ test(function () {
 	Assert::true(Validator::validateNumeric($control));
 	Assert::same('123', $control->value);
 
+	$control->value = 123;
+	Assert::true(Validator::validateNumeric($control));
+	Assert::same(123, $control->value);
+
 	$control->value = '0123';
 	Assert::true(Validator::validateNumeric($control));
 	Assert::same('0123', $control->value);
 
 	$control->value = '-123';
 	Assert::false(Validator::validateNumeric($control));
 
+	$control->value = -123;
+	Assert::false(Validator::validateNumeric($control));
+
 	$control->value = '123.5';
 	Assert::false(Validator::validateNumeric($control));
+
+	$control->value = 123.5;
+	Assert::false(Validator::validateNumeric($control));
 });