JSHint replaced with ESLint

Author: dg

.travis.yml

@@ -31,12 +31,17 @@ jobs:
                 - travis_retry composer create-project nette/code-checker temp/code-checker ~2 --no-progress
                 # Install Nette Coding Standard
                 - travis_retry composer create-project nette/coding-standard temp/coding-standard --no-progress
-                # Install Grunt
+                # Install new Node.js
+                - . $HOME/.nvm/nvm.sh
+                - nvm install stable
+                - nvm use stable
+                # Install Grunt and Eslint
                 - npm install -g grunt-cli; cd tests/netteForms; npm install; cd ../..
             script:
                 - php temp/code-checker/src/code-checker.php --short-arrays --strict-types
                 - php temp/coding-standard/ecs check src tests examples --config temp/coding-standard/coding-standard-php71.neon
                 - grunt --gruntfile=tests/netteForms/Gruntfile.js test
+                - tests/netteForms/node_modules/.bin/eslint src/assets/netteForms.js --config tests/.eslintrc.js
 
 
         -   stage: Code Coverage

src/assets/netteForms.js

@@ -99,8 +99,8 @@
 			return values;
 
 		} else if (elem.name && elem.name.match(/\[\]$/)) { // multiple elements []
-			var elements = elem.form.elements[elem.name].tagName ? [elem] : elem.form.elements[elem.name],
-				values = [];
+			elements = elem.form.elements[elem.name].tagName ? [elem] : elem.form.elements[elem.name];
+			values = [];
 
 			for (i = 0; i < elements.length; i++) {
 				if (elements[i].type !== 'checkbox' || elements[i].checked) {
@@ -425,7 +425,7 @@
 		},
 
 		email: function(elem, arg, val) {
-			return (/^("([ !#-[\]-~]|\\[ -~])+"|[-a-z0-9!#$%&'*+\/=?^_`{|}~]+(\.[-a-z0-9!#$%&'*+\/=?^_`{|}~]+)*)@([0-9a-z\u00C0-\u02FF\u0370-\u1EFF]([-0-9a-z\u00C0-\u02FF\u0370-\u1EFF]{0,61}[0-9a-z\u00C0-\u02FF\u0370-\u1EFF])?\.)+[a-z\u00C0-\u02FF\u0370-\u1EFF]([-0-9a-z\u00C0-\u02FF\u0370-\u1EFF]{0,17}[a-z\u00C0-\u02FF\u0370-\u1EFF])?$/i).test(val);
+			return (/^("([ !#-[\]-~]|\\[ -~])+"|[-a-z0-9!#$%&'*+/=?^_`{|}~]+(\.[-a-z0-9!#$%&'*+/=?^_`{|}~]+)*)@([0-9a-z\u00C0-\u02FF\u0370-\u1EFF]([-0-9a-z\u00C0-\u02FF\u0370-\u1EFF]{0,61}[0-9a-z\u00C0-\u02FF\u0370-\u1EFF])?\.)+[a-z\u00C0-\u02FF\u0370-\u1EFF]([-0-9a-z\u00C0-\u02FF\u0370-\u1EFF]{0,17}[a-z\u00C0-\u02FF\u0370-\u1EFF])?$/i).test(val);
 		},
 
 		url: function(elem, arg, val, value) {
@@ -443,13 +443,13 @@
 			var parts = typeof arg === 'string' ? arg.match(/^\/(.*)\/([imu]*)$/) : false;
 			try {
 				return parts && (new RegExp(parts[1], parts[2].replace('u', ''))).test(val);
-			} catch (e) {}
+			} catch (e) {} // eslint-disable-line no-empty
 		},
 
 		pattern: function(elem, arg, val) {
 			try {
 				return typeof arg === 'string' ? (new RegExp('^(?:' + arg + ')$')).test(val) : null;
-			} catch (e) {}
+			} catch (e) {} // eslint-disable-line no-empty
 		},
 
 		numeric: function(elem, arg, val) {
@@ -539,7 +539,7 @@
 			return true;
 		},
 
-		'static': function (elem, arg, val) {
+		'static': function (elem, arg) {
 			return arg;
 		}
 	};
@@ -637,7 +637,7 @@
 	/**
 	 * Displays or hides HTML element.
 	 */
-	Nette.toggle = function(id, visible, srcElement) {
+	Nette.toggle = function(id, visible, srcElement) { // eslint-disable-line no-unused-vars
 		var elem = document.getElementById(id);
 		if (elem) {
 			elem.style.display = visible ? '' : 'none';

tests/.eslintrc.js

@@ -0,0 +1,25 @@
+module.exports = {
+	"env": {
+		"browser": true,
+		"amd": true,
+		"commonjs": true
+	},
+	"globals": {
+		"Tracy": true
+	},
+	"extends": "eslint:recommended",
+	"rules": {
+		"indent": [
+			"error",
+			"tab"
+		],
+		"quotes": [
+			"error",
+			"single"
+		],
+		"semi": [
+			"error",
+			"always"
+		]
+	}
+};

tests/netteForms/.jshintrc

@@ -1,13 +1,5 @@
 module.exports = function(grunt) {
 	grunt.initConfig({
-		jshint: {
-			options: {
-				jshintrc: '.jshintrc'
-			},
-			all: [
-				'../../src/assets/*.js', '!../../src/assets/*.min.js'
-			]
-		},
 		jasmine: {
 			test: {
 				src: [
@@ -23,10 +15,9 @@ module.exports = function(grunt) {
 		}
 	});
 
-	grunt.loadNpmTasks('grunt-contrib-jshint');
 	grunt.loadNpmTasks('grunt-contrib-jasmine');
 
 	grunt.registerTask('test', [
-		'jshint','jasmine'
+		'jasmine'
 	]);
 };

tests/netteForms/Gruntfile.js

@@ -1,9 +1,9 @@
 {
   "devDependencies": {
-    "grunt": "^1.0.1",
-    "grunt-contrib-jasmine": "^1.0.3",
-    "grunt-contrib-jshint": "^1.0.0",
-    "jasmine": "^2.5.2",
+    "eslint": "^4.19.1",
+    "grunt": "^1.0.3",
+    "grunt-contrib-jasmine": "^1.2.0",
+    "jasmine": "^2.99.0",
     "js-fixtures": "^1.5.3"
   }
 }