BaseControl::$disabled is bool, added $disabledChoices

Author: dg

src/Forms/Controls/BaseControl.php

@@ -45,9 +45,7 @@ abstract class BaseControl extends Nette\ComponentModel\Component implements Con
 	protected mixed $value = null;
 	protected Html $control;
 	protected Html $label;
-
-	/** @var bool|bool[] */
-	protected bool|array $disabled = false;
+	protected bool $disabled = false;
 
 	/** @var callable[][]  extension methods */
 	private static array $extMethods = [];
@@ -198,7 +196,7 @@ public function setDisabled(bool $state = true): static
 	 */
 	public function isDisabled(): bool
 	{
-		return $this->disabled === true;
+		return $this->disabled;
 	}
 
 

src/Forms/Controls/CheckboxList.php

@@ -60,7 +60,7 @@ public function getControl(): Html
 				array_merge($input->attrs, [
 					'id' => null,
 					'checked?' => $this->value,
-					'disabled:' => $this->disabled,
+					'disabled:' => $this->disabled ?: $this->disabledChoices,
 					'required' => null,
 					'data-nette-rules:' => [array_key_first($items) => $input->attrs['data-nette-rules']],
 				]),
@@ -83,7 +83,7 @@ public function getControlPart($key = null): Html
 		return parent::getControl()->addAttributes([
 			'id' => $this->getHtmlId() . '-' . $key,
 			'checked' => in_array($key, (array) $this->value, strict: true),
-			'disabled' => is_array($this->disabled) ? isset($this->disabled[$key]) : $this->disabled,
+			'disabled' => $this->disabled || isset($this->disabledChoices[$key]),
 			'required' => null,
 			'value' => $key,
 		]);

src/Forms/Controls/ChoiceControl.php

@@ -21,6 +21,8 @@
  */
 abstract class ChoiceControl extends BaseControl
 {
+	/** @var bool[] */
+	protected array $disabledChoices = [];
 	private bool $checkDefaultValue = true;
 	private array $items = [];
 
@@ -70,7 +72,7 @@ public function getValue(): mixed
 	{
 		return $this->value !== null
 			&& array_key_exists($this->value, $this->items)
-			&& !isset($this->disabled[$this->value])
+			&& !isset($this->disabledChoices[$this->value])
 			? $this->value
 			: null;
 	}
@@ -129,12 +131,11 @@ public function getSelectedItem(): mixed
 	public function setDisabled(bool|array $value = true): static
 	{
 		if (!is_array($value)) {
+			$this->disabledChoices = [];
 			return parent::setDisabled($value);
 		}
-
-		parent::setDisabled(false);
-		$this->disabled = array_fill_keys($value, value: true);
-		return $this;
+		$this->disabledChoices = array_fill_keys($value, value: true);
+		return parent::setDisabled(false);
 	}
 
 

src/Forms/Controls/MultiChoiceControl.php

@@ -21,6 +21,8 @@
  */
 abstract class MultiChoiceControl extends BaseControl
 {
+	/** @var bool[] */
+	protected array $disabledChoices = [];
 	private bool $checkDefaultValue = true;
 	private array $items = [];
 
@@ -119,7 +121,7 @@ public function getSelectedItems(): array
 	{
 		$res = [];
 		foreach ($this->value as $key) {
-			if (isset($this->items[$key]) && !isset($this->disabled[$key])) {
+			if (isset($this->items[$key]) && !isset($this->disabledChoices[$key])) {
 				$res[$key] = $this->items[$key];
 			}
 		}
@@ -133,12 +135,11 @@ public function getSelectedItems(): array
 	public function setDisabled(bool|array $value = true): static
 	{
 		if (!is_array($value)) {
+			$this->disabledChoices = [];
 			return parent::setDisabled($value);
 		}
-
-		parent::setDisabled(false);
-		$this->disabled = array_fill_keys($value, value: true);
-		return $this;
+		$this->disabledChoices = array_fill_keys($value, value: true);
+		return parent::setDisabled(false);
 	}
 
 

src/Forms/Controls/MultiSelectBox.php

@@ -66,7 +66,7 @@ public function getControl(): Nette\Utils\Html
 		return Nette\Forms\Helpers::createSelectBox(
 			$items,
 			[
-				'disabled:' => is_array($this->disabled) ? $this->disabled : null,
+				'disabled:' => $this->disabledChoices,
 			] + $this->optionAttributes,
 			$this->value,
 		)->addAttributes(parent::getControl()->attrs)->multiple(true);

src/Forms/Controls/RadioList.php

@@ -58,7 +58,7 @@ public function getControl(): Html
 				array_merge($input->attrs, [
 					'id:' => $ids,
 					'checked?' => $this->value,
-					'disabled:' => $this->disabled,
+					'disabled:' => $this->disabled ?: $this->disabledChoices,
 					'data-nette-rules:' => [key($items) => $input->attrs['data-nette-rules']],
 				]),
 				['for:' => $ids] + $this->itemLabel->attrs,
@@ -80,7 +80,7 @@ public function getControlPart($key = null): Html
 		return parent::getControl()->addAttributes([
 			'id' => $this->getHtmlId() . '-' . $key,
 			'checked' => in_array($key, (array) $this->value, strict: true),
-			'disabled' => is_array($this->disabled) ? isset($this->disabled[$key]) : $this->disabled,
+			'disabled' => $this->disabled || isset($this->disabledChoices[$key]),
 			'value' => $key,
 		]);
 	}

src/Forms/Controls/SelectBox.php

@@ -96,7 +96,7 @@ public function getControl(): Nette\Utils\Html
 		}
 
 		$attrs = $this->optionAttributes;
-		$attrs['disabled:'] = is_array($this->disabled) ? $this->disabled : [];
+		$attrs['disabled:'] = $this->disabledChoices;
 
 		$selected = $this->value;
 		if ($this->prompt !== false) {