Form: checks for missing setRequired before render

Author: dg

src/Forms/Form.php

@@ -612,6 +612,9 @@ protected function beforeRender()
 	public function fireRenderEvents()
 	{
 		if (!$this->beforeRenderCalled) {
+			foreach ($this->getComponents(TRUE, Controls\BaseControl::class) as $control) {
+				$control->getRules()->check();
+			}
 			$this->beforeRenderCalled = TRUE;
 			$this->beforeRender();
 			$this->onRender($this);

src/Forms/Rules.php

@@ -251,6 +251,29 @@ public function validate($emptyOptional = FALSE)
 	}
 
 
+	/**
+	 * @internal
+	 */
+	public function check()
+	{
+		if ($this->required !== NULL) {
+			return;
+		}
+		foreach ($this->rules as $rule) {
+			if ($rule->control === $this->control && ($rule->validator === Form::FILLED || $rule->validator === Form::BLANK)) {
+				// ignore
+			} elseif ($rule->branch) {
+				if ($rule->branch->check() === TRUE) {
+					return TRUE;
+				}
+			} else {
+				trigger_error("Missing setRequired(TRUE | FALSE) on field '{$rule->control->getName()}' in form '{$rule->control->getForm()->getName()}'.", E_USER_WARNING);
+				return TRUE;
+			}
+		}
+	}
+
+
 	/**
 	 * Validates single rule.
 	 * @return bool

tests/Forms/Rules.formatMessage.phpt

@@ -13,15 +13,22 @@ require __DIR__ . '/../bootstrap.php';
 
 $form = new Form;
 $form->addText('args1')
-	->addRule(Form::RANGE, '%d %d', [1, 5]);
+	->setRequired()
+	->addRule(Form::RANGE, '%d %d', [1, 5])
+	->setDefaultValue('x');
 
 $form->addText('args2')
-	->addRule(Form::RANGE, '%2$d %1$d', [1, 5]);
+	->setRequired()
+	->addRule(Form::RANGE, '%2$d %1$d', [1, 5])
+	->setDefaultValue('x');
 
 $form->addText('args3')
-	->addRule(Form::LENGTH, '%d %d', 1);
+	->setRequired()
+	->addRule(Form::LENGTH, '%d %d', 1)
+	->setDefaultValue('xyz');
 
 $form->addText('special', 'Label')
+	->setRequired()
 	->addRule(Form::EMAIL, '%label %value is invalid [field %name] %d', $form['special'])
 	->setDefaultValue('xyz');
 
@@ -41,4 +48,4 @@ Assert::same(['1 '], $form['args3']->getErrors());
 
 Assert::same(['Label xyz is invalid [field special] xyz'], $form['special']->getErrors());
 
-Assert::match('%A%data-nette-rules=\'[{"op":":email","msg":"Label %value is invalid [field special] %0"%A%', $form->__toString(TRUE));
+Assert::match('%A%data-nette-rules=\'%A%{"op":":email","msg":"Label %value is invalid [field special] %0"%A%', $form->__toString(TRUE));