BaseControl::setAttribute() and setType() marked as deprecated

Author: dg

src/Forms/Controls/BaseControl.php

@@ -350,20 +350,17 @@ public function getHtmlId()
 	 */
 	public function setHtmlAttribute($name, $value = TRUE)
 	{
-		return $this->setAttribute($name, $value);
+		$this->control->$name = $value;
+		return $this;
 	}
 
 
 	/**
-	 * Alias for setHtmlAttribute()
-	 * @param  string name
-	 * @param  mixed  value
-	 * @return static
+	 * @deprecated  use setHtmlAttribute()
 	 */
 	public function setAttribute($name, $value = TRUE)
 	{
-		$this->control->$name = $value;
-		return $this;
+		return $this->setHtmlAttribute($name, $value);
 	}
 
 

src/Forms/Controls/TextInput.php

@@ -48,19 +48,17 @@ public function loadHttpData()
 	 */
 	public function setHtmlType($type)
 	{
-		return $this->setType($type);
+		$this->control->type = $type;
+		return $this;
 	}
 
 
 	/**
-	 * Alias for setHtmlType()
-	 * @param  string
-	 * @return static
+	 * @deprecated  use setHtmlType()
 	 */
 	public function setType($type)
 	{
-		$this->control->type = $type;
-		return $this;
+		return $this->setHtmlType($type);
 	}