BaseControl::getHtmlId() ensures that control is attached to the form (BC break)

Author: dg

src/Forms/Controls/BaseControl.php

@@ -336,8 +336,8 @@ public function setHtmlId($id)
 	public function getHtmlId()
 	{
 		if (!isset($this->control->id)) {
-			$form = $this->getForm(false);
-			$this->control->id = sprintf(self::$idMask, $this->lookupPath(), $form ? $form->getName() : '');
+			$form = $this->getForm();
+			$this->control->id = sprintf(self::$idMask, $this->lookupPath(), $form->getName());
 		}
 		return $this->control->id;
 	}

tests/Forms/Forms.idMask.phpt

@@ -13,15 +13,15 @@ require __DIR__ . '/../bootstrap.php';
 Assert::exception(function () {
 	$input = new TextInput('name');
 	$input->getHtmlId();
-}, Nette\InvalidStateException::class, "Component '' is not attached to ''.");
+}, Nette\InvalidStateException::class, "Component '' is not attached to 'Nette\\Forms\\Form'.");
 
 
-test(function () {
+Assert::exception(function () {
 	$container = new Nette\Forms\Container;
 	$container->setParent(null, 'second');
 	$input = $container->addText('name');
-	Assert::same('frm-name', $input->getHtmlId());
-});
+	$input->getHtmlId();
+}, Nette\InvalidStateException::class, "Component 'name' is not attached to 'Nette\\Forms\\Form'.");
 
 
 test(function () {