Revert "addText(), addPassword() and addTextArea() deprecated third parameter $cols (and $rows) (BC break!)"

This reverts commit f5f00a2.

Author: dg

src/Forms/Container.php

@@ -238,10 +238,7 @@ public function getForm($need = TRUE)
 	public function addText($name, $label = NULL, $cols = NULL, $maxLength = NULL)
 	{
 		$control = new Controls\TextInput($label, $maxLength);
-		if ($cols) {
-			trigger_error(__METHOD__ . '() third parameter $cols is deprecated, use setAttribute("size", ...).', E_USER_DEPRECATED);
-			$control->setAttribute('size', $cols);
-		}
+		$control->setAttribute('size', $cols);
 		return $this[$name] = $control;
 	}
 
@@ -257,10 +254,7 @@ public function addText($name, $label = NULL, $cols = NULL, $maxLength = NULL)
 	public function addPassword($name, $label = NULL, $cols = NULL, $maxLength = NULL)
 	{
 		$control = new Controls\TextInput($label, $maxLength);
-		if ($cols) {
-			trigger_error(__METHOD__ . '() third parameter $cols is deprecated, use setAttribute("size", ...).', E_USER_DEPRECATED);
-			$control->setAttribute('size', $cols);
-		}
+		$control->setAttribute('size', $cols);
 		return $this[$name] = $control->setType('password');
 	}
 
@@ -276,11 +270,8 @@ public function addPassword($name, $label = NULL, $cols = NULL, $maxLength = NUL
 	public function addTextArea($name, $label = NULL, $cols = NULL, $rows = NULL)
 	{
 		$control = new Controls\TextArea($label);
-		if ($cols) {
-			trigger_error(__METHOD__ . '() parameters $cols is deprecated, use setAttribute("cols", ...).', E_USER_DEPRECATED);
-			$control->setAttribute('cols', $cols);
-		}
-		return $this[$name] = $control->setAttribute('rows', $rows);
+		$control->setAttribute('cols', $cols)->setAttribute('rows', $rows);
+		return $this[$name] = $control;
 	}
 
 

tests/Forms.Latte/expected/FormMacros.forms.html

@@ -9,13 +9,13 @@
 		 <input type="hidden" name="id" value="" title="Hello" size="10">
 
 		<label for="frm-username">Username:</label>
-		<input type="text" name="username" id="frm-username" title="Hello" size="10">
+		<input type="text" name="username" size="10" id="frm-username" title="Hello">
 		error
 		error
 
 		<br>
 
-		<label for="frm-username" title="hello"> <input type="text" name="username" id="frm-username" title="Hello" size="10"> </label>
+		<label for="frm-username" title="hello"> <input type="text" name="username" size="10" id="frm-username" title="Hello"> </label>
 		error
 		<label for="frm-select"></label>
 		<select name="select" id="frm-select" title="Hello" size="10"><option value="m">male</option><option value="f">female</option></select>