Helpers::$unsafeNames changed to const

dg · dg · commit 72d285661dbb · 2019-02-05T14:47:01.000+01:00
diff --git a/src/Forms/Helpers.php b/src/Forms/Helpers.php
@@ -21,7 +21,7 @@ class Helpers
 {
 	use Nette\StaticClass;
 
-	private static $unsafeNames = [
+	private const UNSAFE_NAMES = [
 		'attributes', 'children', 'elements', 'focus', 'length', 'reset', 'style', 'submit', 'onsubmit', 'form',
 		'presenter', 'action',
 	];
@@ -85,7 +85,7 @@ public static function generateHtmlName(string $id): string
 		if ($count) {
 			$name = substr_replace($name, '', strpos($name, ']'), 1) . ']';
 		}
-		if (is_numeric($name) || in_array($name, self::$unsafeNames, true)) {
+		if (is_numeric($name) || in_array($name, self::UNSAFE_NAMES, true)) {
 			$name = '_' . $name;
 		}
 		return $name;

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class Helpers`
`21`	`21`	`{`
`22`	`22`	`use Nette\StaticClass;`
`23`	`23`
`24`		`- private static $unsafeNames = [`
	`24`	`+ private const UNSAFE_NAMES = [`
`25`	`25`	`'attributes', 'children', 'elements', 'focus', 'length', 'reset', 'style', 'submit', 'onsubmit', 'form',`
`26`	`26`	`'presenter', 'action',`
`27`	`27`	`];`
`@@ -85,7 +85,7 @@ public static function generateHtmlName(string $id): string`
`85`	`85`	`if ($count) {`
`86`	`86`	`$name = substr_replace($name, '', strpos($name, ']'), 1) . ']';`
`87`	`87`	`}`
`88`		`- if (is_numeric($name) \|\| in_array($name, self::$unsafeNames, true)) {`
	`88`	`+ if (is_numeric($name) \|\| in_array($name, self::UNSAFE_NAMES, true)) {`
`89`	`89`	`$name = '_' . $name;`
`90`	`90`	`}`
`91`	`91`	`return $name;`