addRule(~Form::REQUIRED) is converted to Form::BLANK and has different meaning than not-required (BC break)

Author: dg

src/Forms/Rules.php

@@ -64,7 +64,7 @@ public function setRequired($value = TRUE)
 	 */
 	public function isRequired()
 	{
-		return $this->required instanceof Rule ? !$this->required->isNegative : FALSE;
+		return (bool) $this->required;
 	}
 
 
@@ -281,6 +281,11 @@ private function adjustOperation($rule)
 				$name = strncmp($rule->validator, ':', 1) ? $rule->validator : 'Form:' . strtoupper($rule->validator);
 				trigger_error("Negative validation rules such as ~$name are deprecated.", E_USER_DEPRECATED);
 			}
+			if ($rule->validator === Form::FILLED) {
+				$rule->validator = Form::BLANK;
+				$rule->isNegative = FALSE;
+				trigger_error('Replace negative validation rule ~Form::FILLED with Form::BLANK.', E_USER_DEPRECATED);
+			}
 		}
 
 		if (!is_callable($this->getCallback($rule))) {

tests/Forms/Rules.required.phpt

@@ -57,13 +57,12 @@ test(function () { // 'required' is always the first rule
 
 	@$rules->addRule(~$form::REQUIRED); // @ - negative rules are deprecated
 	$items = iterator_to_array($rules);
-	Assert::count(2, $items);
-	Assert::same(Form::REQUIRED, $items[0]->validator);
-	Assert::true($items[0]->isNegative);
-	Assert::same(Form::EMAIL, $items[1]->validator);
+	Assert::count(3, $items);
+	Assert::same(Form::BLANK, $items[2]->validator);
+	Assert::false($items[2]->isNegative);
 
 	Assert::false($rules->validate());
-	Assert::same(['Please enter a valid email address.'], $input->getErrors());
+	Assert::same(['This field is required.'], $input->getErrors());
 });