Session::setExpiration() checks for null instead of empty()

dg · dg · commit 31b10d748e2c · 2021-01-04T03:04:08.000+01:00
diff --git a/src/Http/Session.php b/src/Http/Session.php
@@ -431,7 +431,7 @@ private function configure(array $config): void
 	 */
 	public function setExpiration(?string $time)
 	{
-		if (empty($time)) {
+		if ($time === null) {
 			return $this->setOptions([
 				'gc_maxlifetime' => self::DEFAULT_FILE_LIFETIME,
 				'cookie_lifetime' => 0,

Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,7 @@ private function configure(array $config): void`
`431`	`431`	`*/`
`432`	`432`	`public function setExpiration(?string $time)`
`433`	`433`	`{`
`434`		`- if (empty($time)) {`
	`434`	`+ if ($time === null) {`
`435`	`435`	`return $this->setOptions([`
`436`	`436`	`'gc_maxlifetime' => self::DEFAULT_FILE_LIFETIME,`
`437`	`437`	`'cookie_lifetime' => 0,`