Http\Response::setCode produces valid HTTP header on nginx (#113)

ondrejmirtes · dg · commit 71602f2ab582 · 2016-12-19T15:56:54.000+01:00
diff --git a/src/Http/Response.php b/src/Http/Response.php
@@ -66,8 +66,7 @@ public function setCode($code)
 		}
 		self::checkHeaders();
 		$this->code = $code;
-		$protocol = isset($_SERVER['SERVER_PROTOCOL']) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.1';
-		header($protocol . ' ' . $code, TRUE, $code);
+		http_response_code($code);
 		return $this;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -66,8 +66,7 @@ public function setCode($code)`
`66`	`66`	`}`
`67`	`67`	`self::checkHeaders();`
`68`	`68`	`$this->code = $code;`
`69`		`- $protocol = isset($_SERVER['SERVER_PROTOCOL']) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.1';`
`70`		`- header($protocol . ' ' . $code, TRUE, $code);`
	`69`	`+ http_response_code($code);`
`71`	`70`	`return $this;`
`72`	`71`	`}`
`73`	`72`