Skip to content

Commit 88784b1

Browse files
committed
Merge pull request #21 from JanTvrdik/multiple_keys
Fix Http\Request::getFile() inconsistency
2 parents 57b6dbd + 8312261 commit 88784b1

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

src/Http/IRequest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ function getPost($key = NULL, $default = NULL);
5353

5454
/**
5555
* Returns uploaded file.
56-
* @param string key (or more keys)
56+
* @param string key
5757
* @return FileUpload|NULL
5858
*/
5959
function getFile($key);

src/Http/Request.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,12 +139,17 @@ public function getPost($key = NULL, $default = NULL)
139139

140140
/**
141141
* Returns uploaded file.
142-
* @param string key (or more keys)
142+
* @param string key
143143
* @return FileUpload|NULL
144144
*/
145145
public function getFile($key)
146146
{
147-
return Nette\Utils\Arrays::get($this->files, func_get_args(), NULL);
147+
if (func_num_args() > 1) {
148+
trigger_error('Calling getFile() with multiple keys is deprecated.', E_USER_DEPRECATED);
149+
return Nette\Utils\Arrays::get($this->files, func_get_args(), NULL);
150+
}
151+
152+
return isset($this->files[$key]) ? $this->files[$key] : NULL;
148153
}
149154

150155

tests/Http/Request.files.phpt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,5 @@ Assert::type( 'Nette\Http\FileUpload', $request->files['file3'][1] );
108108
Assert::false( isset($request->files['file0']) );
109109
Assert::true( isset($request->files['file1']) );
110110

111-
Assert::null( $request->getFile('file1', 'a') );
112-
113111
Assert::null( $request->getFile('empty1') );
114112
Assert::same( array(NULL), $request->getFile('empty2') );

0 commit comments

Comments
 (0)