coding style: fixes in code

dg · dg · commit 920984c48f59 · 2017-07-11T13:48:05.000+02:00
diff --git a/src/Bridges/HttpDI/SessionExtension.php b/src/Bridges/HttpDI/SessionExtension.php
@@ -53,7 +53,7 @@ public function loadConfiguration()
 
 		if ($this->debugMode && $config['debugger']) {
 			$session->addSetup('@Tracy\Bar::addPanel', [
-				new Nette\DI\Statement(Nette\Bridges\HttpTracy\SessionPanel::class)
+				new Nette\DI\Statement(Nette\Bridges\HttpTracy\SessionPanel::class),
 			]);
 		}
 
diff --git a/src/Http/Request.php b/src/Http/Request.php
@@ -277,7 +277,7 @@ public function getRemoteAddress()
 	public function getRemoteHost()
 	{
 		if ($this->remoteHost === null && $this->remoteAddress !== null) {
-			$this->remoteHost = getHostByAddr($this->remoteAddress);
+			$this->remoteHost = gethostbyaddr($this->remoteAddress);
 		}
 		return $this->remoteHost;
 	}
diff --git a/src/Http/RequestFactory.php b/src/Http/RequestFactory.php
@@ -101,7 +101,7 @@ public function createHttpRequest()
 		$url->setScriptPath($path);
 
 		// GET, POST, COOKIE
-		$useFilter = (!in_array(ini_get('filter.default'), ['', 'unsafe_raw']) || ini_get('filter.default_flags'));
+		$useFilter = (!in_array(ini_get('filter.default'), ['', 'unsafe_raw'], true) || ini_get('filter.default_flags'));
 
 		$query = $url->getQueryParameters();
 		$post = $useFilter ? filter_input_array(INPUT_POST, FILTER_UNSAFE_RAW) : (empty($_POST) ? [] : $_POST);
@@ -186,7 +186,7 @@ public function createHttpRequest()
 				} elseif (strncmp($k, 'CONTENT_', 8)) {
 					continue;
 				}
-				$headers[ strtr($k, '_', '-') ] = $v;
+				$headers[strtr($k, '_', '-')] = $v;
 			}
 		}
 
diff --git a/src/Http/Response.php b/src/Http/Response.php
@@ -20,9 +20,6 @@ class Response implements IResponse
 {
 	use Nette\SmartObject;
 
-	/** @var bool  Send invisible garbage for IE 6? */
-	private static $fixIE = true;
-
 	/** @var string The domain in which the cookie will be available */
 	public $cookieDomain = '';
 
@@ -38,6 +35,9 @@ class Response implements IResponse
 	/** @var bool Whether warn on possible problem with data in output buffer */
 	public $warnOnBuffer = true;
 
+	/** @var bool  Send invisible garbage for IE 6? */
+	private static $fixIE = true;
+
 	/** @var int HTTP response code */
 	private $code = self::S200_OK;
 
@@ -156,7 +156,7 @@ public function redirect($url, $code = self::S302_FOUND)
 		$this->setCode($code);
 		$this->setHeader('Location', $url);
 		if (preg_match('#^https?:|^\s*+[a-z0-9+.-]*+[^:]#i', $url)) {
-			$escapedUrl = htmlSpecialChars($url, ENT_IGNORE | ENT_QUOTES, 'UTF-8');
+			$escapedUrl = htmlspecialchars($url, ENT_IGNORE | ENT_QUOTES, 'UTF-8');
 			echo "<h1>Redirect</h1>\n\n<p><a href=\"$escapedUrl\">Please click here to continue</a>.</p>";
 		}
 	}
diff --git a/src/Http/Session.php b/src/Http/Session.php
@@ -39,7 +39,7 @@ class Session
 		'cookie_path' => '/',     // cookie is available within the entire domain
 		'cookie_domain' => '',    // cookie is available on current subdomain only
 		'cookie_secure' => false, // cookie is available on HTTP & HTTPS
-		'cookie_httponly' => true,// must be enabled to prevent Session Hijacking
+		'cookie_httponly' => true, // must be enabled to prevent Session Hijacking
 
 		// other
 		'gc_maxlifetime' => self::DEFAULT_FILE_LIFETIME, // 3 hours
diff --git a/src/Http/SessionSection.php b/src/Http/SessionSection.php
@@ -17,6 +17,9 @@ class SessionSection implements \IteratorAggregate, \ArrayAccess
 {
 	use Nette\SmartObject;
 
+	/** @var bool */
+	public $warnOnUndefined = false;
+
 	/** @var Session */
 	private $session;
 
@@ -29,9 +32,6 @@ class SessionSection implements \IteratorAggregate, \ArrayAccess
 	/** @var array  session metadata storage */
 	private $meta = false;
 
-	/** @var bool */
-	public $warnOnUndefined = false;
-
 
 	/**
 	 * Do not call directly. Use Session::getSection().
diff --git a/tests/Http/Request.request.phpt b/tests/Http/Request.request.phpt
@@ -28,28 +28,28 @@ test(function () {
 	$factory->urlFilters['url'] = ['#[.,)]\z#' => ''];
 	$request = $factory->createHttpRequest();
 
-	Assert::same('GET',  $request->getMethod());
+	Assert::same('GET', $request->getMethod());
 	Assert::true($request->isSecured());
-	Assert::same('192.168.188.66',  $request->getRemoteAddress());
+	Assert::same('192.168.188.66', $request->getRemoteAddress());
 
-	Assert::same('/file.php',  $request->getUrl()->scriptPath);
-	Assert::same('https',  $request->getUrl()->scheme);
-	Assert::same('',  $request->getUrl()->user);
-	Assert::same('',  $request->getUrl()->password);
-	Assert::same('nette.org',  $request->getUrl()->host);
-	Assert::same(8080,  $request->getUrl()->port);
-	Assert::same('/file.php',  $request->getUrl()->path);
-	Assert::same('x_param=val.&pa%25ram=val2&quotes%5C%22=%5C%22&param3=v%20a%26l%3Du%2Be',  $request->getUrl()->query);
-	Assert::same('',  $request->getUrl()->fragment);
-	Assert::same('val.',  $request->getQuery('x_param'));
-	Assert::same('val2',  $request->getQuery('pa%ram'));
-	Assert::same('nette.org:8080',  $request->getUrl()->authority);
-	Assert::same('https://nette.org:8080',  $request->getUrl()->hostUrl);
-	Assert::same('https://nette.org:8080/',  $request->getUrl()->baseUrl);
-	Assert::same('/',  $request->getUrl()->basePath);
-	Assert::same('file.php?x_param=val.&pa%25ram=val2&quotes%5C%22=%5C%22&param3=v%20a%26l%3Du%2Be',  $request->getUrl()->relativeUrl);
-	Assert::same('https://nette.org:8080/file.php?x_param=val.&pa%25ram=val2&quotes%5C%22=%5C%22&param3=v%20a%26l%3Du%2Be',  $request->getUrl()->absoluteUrl);
-	Assert::same('',  $request->getUrl()->pathInfo);
+	Assert::same('/file.php', $request->getUrl()->scriptPath);
+	Assert::same('https', $request->getUrl()->scheme);
+	Assert::same('', $request->getUrl()->user);
+	Assert::same('', $request->getUrl()->password);
+	Assert::same('nette.org', $request->getUrl()->host);
+	Assert::same(8080, $request->getUrl()->port);
+	Assert::same('/file.php', $request->getUrl()->path);
+	Assert::same('x_param=val.&pa%25ram=val2&quotes%5C%22=%5C%22&param3=v%20a%26l%3Du%2Be', $request->getUrl()->query);
+	Assert::same('', $request->getUrl()->fragment);
+	Assert::same('val.', $request->getQuery('x_param'));
+	Assert::same('val2', $request->getQuery('pa%ram'));
+	Assert::same('nette.org:8080', $request->getUrl()->authority);
+	Assert::same('https://nette.org:8080', $request->getUrl()->hostUrl);
+	Assert::same('https://nette.org:8080/', $request->getUrl()->baseUrl);
+	Assert::same('/', $request->getUrl()->basePath);
+	Assert::same('file.php?x_param=val.&pa%25ram=val2&quotes%5C%22=%5C%22&param3=v%20a%26l%3Du%2Be', $request->getUrl()->relativeUrl);
+	Assert::same('https://nette.org:8080/file.php?x_param=val.&pa%25ram=val2&quotes%5C%22=%5C%22&param3=v%20a%26l%3Du%2Be', $request->getUrl()->absoluteUrl);
+	Assert::same('', $request->getUrl()->pathInfo);
 });
 
 
@@ -59,18 +59,18 @@ test(function () {
 	$factory->urlFilters['url'] = [];
 	$request = $factory->createHttpRequest();
 
-	Assert::same('https',  $request->getUrl()->scheme);
-	Assert::same('',  $request->getUrl()->user);
-	Assert::same('',  $request->getUrl()->password);
-	Assert::same('nette.org',  $request->getUrl()->host);
-	Assert::same(8080,  $request->getUrl()->port);
-	Assert::same('/file.php',  $request->getUrl()->path);
-	Assert::same('x_param=val.&pa%25ram=val2&quotes%5C%22=%5C%22&param3=v%20a%26l%3Du%2Be%29',  $request->getUrl()->query);
-	Assert::same('',  $request->getUrl()->fragment);
-	Assert::same('val.',  $request->getQuery('x_param'));
-	Assert::same('val2',  $request->getQuery('pa%ram'));
-	Assert::same('v a&l=u+e)',  $request->getQuery('param3'));
+	Assert::same('https', $request->getUrl()->scheme);
+	Assert::same('', $request->getUrl()->user);
+	Assert::same('', $request->getUrl()->password);
+	Assert::same('nette.org', $request->getUrl()->host);
+	Assert::same(8080, $request->getUrl()->port);
+	Assert::same('/file.php', $request->getUrl()->path);
+	Assert::same('x_param=val.&pa%25ram=val2&quotes%5C%22=%5C%22&param3=v%20a%26l%3Du%2Be%29', $request->getUrl()->query);
+	Assert::same('', $request->getUrl()->fragment);
+	Assert::same('val.', $request->getQuery('x_param'));
+	Assert::same('val2', $request->getQuery('pa%ram'));
+	Assert::same('v a&l=u+e)', $request->getQuery('param3'));
 	if (!function_exists('apache_request_headers')) {
-		Assert::same('nette.org:8080',  $request->headers['host']);
+		Assert::same('nette.org:8080', $request->headers['host']);
 	}
 });
diff --git a/tests/Http/Session.handler.phpt b/tests/Http/Session.handler.phpt
@@ -15,38 +15,38 @@ class MySessionStorage implements SessionHandlerInterface
 	private $path;
 
 
-	function open($savePath, $sessionName)
+	public function open($savePath, $sessionName)
 	{
 		$this->path = $savePath;
 		return true;
 	}
 
 
-	function close()
+	public function close()
 	{
 		return true;
 	}
 
 
-	function read($id)
+	public function read($id)
 	{
 		return (string) @file_get_contents("$this->path/sess_$id");
 	}
 
 
-	function write($id, $data)
+	public function write($id, $data)
 	{
 		return (bool) file_put_contents("$this->path/sess_$id", $data);
 	}
 
 
-	function destroy($id)
+	public function destroy($id)
 	{
 		return !is_file("$this->path/sess_$id") || @unlink("$this->path/sess_$id");
 	}
 
 
-	function gc($maxlifetime)
+	public function gc($maxlifetime)
 	{
 		foreach (glob("$this->path/sess_*") as $filename) {
 			if (filemtime($filename) + $maxlifetime < time()) {
diff --git a/tests/Http/Session.storage.phpt b/tests/Http/Session.storage.phpt
@@ -17,38 +17,38 @@ class MySessionStorage implements ISessionStorage
 	private $path;
 
 
-	function open($savePath, $sessionName)
+	public function open($savePath, $sessionName)
 	{
 		$this->path = $savePath;
 		return true;
 	}
 
 
-	function close()
+	public function close()
 	{
 		return true;
 	}
 
 
-	function read($id)
+	public function read($id)
 	{
 		return (string) @file_get_contents("$this->path/sess_$id");
 	}
 
 
-	function write($id, $data)
+	public function write($id, $data)
 	{
 		return (bool) file_put_contents("$this->path/sess_$id", $data);
 	}
 
 
-	function remove($id)
+	public function remove($id)
 	{
 		return !is_file("$this->path/sess_$id") || @unlink("$this->path/sess_$id");
 	}
 
 
-	function clean($maxlifetime)
+	public function clean($maxlifetime)
 	{
 		foreach (glob("$this->path/sess_*") as $filename) {
 			if (filemtime($filename) + $maxlifetime < time()) {
diff --git a/tests/Http/SessionSection.basic.phpt b/tests/Http/SessionSection.basic.phpt
@@ -32,9 +32,9 @@ Assert::true(isset($namespace['p']));
 Assert::true(isset($namespace->o));
 Assert::false(isset($namespace->undefined));
 
-unset($namespace['a']);
-unset($namespace->p);
-unset($namespace->o);
-unset($namespace->undef);
+unset($namespace['a'], $namespace->p, $namespace->o, $namespace->undef);
+
+
+
 
 Assert::same('', http_build_query($namespace->getIterator()));
diff --git a/tests/Http/Url.fileScheme.phpt b/tests/Http/Url.fileScheme.phpt
@@ -13,27 +13,27 @@ require __DIR__ . '/../bootstrap.php';
 
 test(function () {
 	$url = new Url('file://localhost/D:/dokumentace/rfc3986.txt');
-	Assert::same('file://localhost/D:/dokumentace/rfc3986.txt',  (string) $url);
-	Assert::same('file',  $url->scheme);
-	Assert::same('',  $url->user);
-	Assert::same('',  $url->password);
-	Assert::same('localhost',  $url->host);
+	Assert::same('file://localhost/D:/dokumentace/rfc3986.txt', (string) $url);
+	Assert::same('file', $url->scheme);
+	Assert::same('', $url->user);
+	Assert::same('', $url->password);
+	Assert::same('localhost', $url->host);
 	Assert::null($url->port);
-	Assert::same('/D:/dokumentace/rfc3986.txt',  $url->path);
-	Assert::same('',  $url->query);
-	Assert::same('',  $url->fragment);
+	Assert::same('/D:/dokumentace/rfc3986.txt', $url->path);
+	Assert::same('', $url->query);
+	Assert::same('', $url->fragment);
 });
 
 
 test(function () {
 	$url = new Url('file:///D:/dokumentace/rfc3986.txt');
-	Assert::same('file://D:/dokumentace/rfc3986.txt',  (string) $url);
-	Assert::same('file',  $url->scheme);
-	Assert::same('',  $url->user);
-	Assert::same('',  $url->password);
-	Assert::same('',  $url->host);
+	Assert::same('file://D:/dokumentace/rfc3986.txt', (string) $url);
+	Assert::same('file', $url->scheme);
+	Assert::same('', $url->user);
+	Assert::same('', $url->password);
+	Assert::same('', $url->host);
 	Assert::null($url->port);
-	Assert::same('D:/dokumentace/rfc3986.txt',  $url->path);
-	Assert::same('',  $url->query);
-	Assert::same('',  $url->fragment);
+	Assert::same('D:/dokumentace/rfc3986.txt', $url->path);
+	Assert::same('', $url->query);
+	Assert::same('', $url->fragment);
 });
diff --git a/tests/Http/Url.ftpScheme.phpt b/tests/Http/Url.ftpScheme.phpt
@@ -13,14 +13,14 @@ require __DIR__ . '/../bootstrap.php';
 
 $url = new Url('ftp://ftp.is.co.za/rfc/rfc3986.txt');
 
-Assert::same('ftp',  $url->scheme);
-Assert::same('',  $url->user);
-Assert::same('',  $url->password);
-Assert::same('ftp.is.co.za',  $url->host);
-Assert::same(21,  $url->port);
-Assert::same('/rfc/rfc3986.txt',  $url->path);
-Assert::same('',  $url->query);
-Assert::same('',  $url->fragment);
-Assert::same('ftp.is.co.za',  $url->authority);
-Assert::same('ftp://ftp.is.co.za',  $url->hostUrl);
-Assert::same('ftp://ftp.is.co.za/rfc/rfc3986.txt',  $url->absoluteUrl);
+Assert::same('ftp', $url->scheme);
+Assert::same('', $url->user);
+Assert::same('', $url->password);
+Assert::same('ftp.is.co.za', $url->host);
+Assert::same(21, $url->port);
+Assert::same('/rfc/rfc3986.txt', $url->path);
+Assert::same('', $url->query);
+Assert::same('', $url->fragment);
+Assert::same('ftp.is.co.za', $url->authority);
+Assert::same('ftp://ftp.is.co.za', $url->hostUrl);
+Assert::same('ftp://ftp.is.co.za/rfc/rfc3986.txt', $url->absoluteUrl);
diff --git a/tests/Http/Url.httpScheme.phpt b/tests/Http/Url.httpScheme.phpt
diff --git a/tests/Http/Url.query.phpt b/tests/Http/Url.query.phpt
diff --git a/tests/Http/UrlScript.modify.phpt b/tests/Http/UrlScript.modify.phpt
diff --git a/tests/Http/UrlScript.parse.phpt b/tests/Http/UrlScript.parse.phpt

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public function loadConfiguration()`
`53`	`53`
`54`	`54`	`if ($this->debugMode && $config['debugger']) {`
`55`	`55`	`$session->addSetup('@Tracy\Bar::addPanel', [`
`56`		`- new Nette\DI\Statement(Nette\Bridges\HttpTracy\SessionPanel::class)`
	`56`	`+ new Nette\DI\Statement(Nette\Bridges\HttpTracy\SessionPanel::class),`
`57`	`57`	`]);`
`58`	`58`	`}`
`59`	`59`
Original file line number	Diff line number	Diff line change
`@@ -277,7 +277,7 @@ public function getRemoteAddress()`
`277`	`277`	`public function getRemoteHost()`
`278`	`278`	`{`
`279`	`279`	`if ($this->remoteHost === null && $this->remoteAddress !== null) {`
`280`		`- $this->remoteHost = getHostByAddr($this->remoteAddress);`
	`280`	`+ $this->remoteHost = gethostbyaddr($this->remoteAddress);`
`281`	`281`	`}`
`282`	`282`	`return $this->remoteHost;`
`283`	`283`	`}`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ public function createHttpRequest()`
`101`	`101`	`$url->setScriptPath($path);`
`102`	`102`
`103`	`103`	`// GET, POST, COOKIE`
`104`		`- $useFilter = (!in_array(ini_get('filter.default'), ['', 'unsafe_raw']) \|\| ini_get('filter.default_flags'));`
	`104`	`+ $useFilter = (!in_array(ini_get('filter.default'), ['', 'unsafe_raw'], true) \|\| ini_get('filter.default_flags'));`
`105`	`105`
`106`	`106`	`$query = $url->getQueryParameters();`
`107`	`107`	`$post = $useFilter ? filter_input_array(INPUT_POST, FILTER_UNSAFE_RAW) : (empty($_POST) ? [] : $_POST);`
`@@ -186,7 +186,7 @@ public function createHttpRequest()`
`186`	`186`	`} elseif (strncmp($k, 'CONTENT_', 8)) {`
`187`	`187`	`continue;`
`188`	`188`	`}`
`189`		`- $headers[ strtr($k, '_', '-') ] = $v;`
	`189`	`+ $headers[strtr($k, '_', '-')] = $v;`
`190`	`190`	`}`
`191`	`191`	`}`
`192`	`192`
Original file line number	Diff line number	Diff line change
`@@ -15,38 +15,38 @@ class MySessionStorage implements SessionHandlerInterface`
`15`	`15`	`private $path;`
`16`	`16`
`17`	`17`
`18`		`- function open($savePath, $sessionName)`
	`18`	`+ public function open($savePath, $sessionName)`
`19`	`19`	`{`
`20`	`20`	`$this->path = $savePath;`
`21`	`21`	`return true;`
`22`	`22`	`}`
`23`	`23`
`24`	`24`
`25`		`- function close()`
	`25`	`+ public function close()`
`26`	`26`	`{`
`27`	`27`	`return true;`
`28`	`28`	`}`
`29`	`29`
`30`	`30`
`31`		`- function read($id)`
	`31`	`+ public function read($id)`
`32`	`32`	`{`
`33`	`33`	`return (string) @file_get_contents("$this->path/sess_$id");`
`34`	`34`	`}`
`35`	`35`
`36`	`36`
`37`		`- function write($id, $data)`
	`37`	`+ public function write($id, $data)`
`38`	`38`	`{`
`39`	`39`	`return (bool) file_put_contents("$this->path/sess_$id", $data);`
`40`	`40`	`}`
`41`	`41`
`42`	`42`
`43`		`- function destroy($id)`
	`43`	`+ public function destroy($id)`
`44`	`44`	`{`
`45`	`45`	`return !is_file("$this->path/sess_$id") \|\| @unlink("$this->path/sess_$id");`
`46`	`46`	`}`
`47`	`47`
`48`	`48`
`49`		`- function gc($maxlifetime)`
	`49`	`+ public function gc($maxlifetime)`
`50`	`50`	`{`
`51`	`51`	`foreach (glob("$this->path/sess_*") as $filename) {`
`52`	`52`	`if (filemtime($filename) + $maxlifetime < time()) {`
Original file line number	Diff line number	Diff line change
`@@ -17,38 +17,38 @@ class MySessionStorage implements ISessionStorage`
`17`	`17`	`private $path;`
`18`	`18`
`19`	`19`
`20`		`- function open($savePath, $sessionName)`
	`20`	`+ public function open($savePath, $sessionName)`
`21`	`21`	`{`
`22`	`22`	`$this->path = $savePath;`
`23`	`23`	`return true;`
`24`	`24`	`}`
`25`	`25`
`26`	`26`
`27`		`- function close()`
	`27`	`+ public function close()`
`28`	`28`	`{`
`29`	`29`	`return true;`
`30`	`30`	`}`
`31`	`31`
`32`	`32`
`33`		`- function read($id)`
	`33`	`+ public function read($id)`
`34`	`34`	`{`
`35`	`35`	`return (string) @file_get_contents("$this->path/sess_$id");`
`36`	`36`	`}`
`37`	`37`
`38`	`38`
`39`		`- function write($id, $data)`
	`39`	`+ public function write($id, $data)`
`40`	`40`	`{`
`41`	`41`	`return (bool) file_put_contents("$this->path/sess_$id", $data);`
`42`	`42`	`}`
`43`	`43`
`44`	`44`
`45`		`- function remove($id)`
	`45`	`+ public function remove($id)`
`46`	`46`	`{`
`47`	`47`	`return !is_file("$this->path/sess_$id") \|\| @unlink("$this->path/sess_$id");`
`48`	`48`	`}`
`49`	`49`
`50`	`50`
`51`		`- function clean($maxlifetime)`
	`51`	`+ public function clean($maxlifetime)`
`52`	`52`	`{`
`53`	`53`	`foreach (glob("$this->path/sess_*") as $filename) {`
`54`	`54`	`if (filemtime($filename) + $maxlifetime < time()) {`