ClassType: constants are 'public' by default

Author: dg

src/PhpGenerator/ClassType.php

@@ -421,7 +421,7 @@ public function getConstants(): array
 
 	public function addConstant(string $name, $value): Constant
 	{
-		return $this->consts[$name] = (new Constant($name))->setValue($value);
+		return $this->consts[$name] = (new Constant($name))->setValue($value)->setPublic();
 	}
 
 

tests/PhpGenerator/Printer.phpt

@@ -27,7 +27,7 @@ $class->addConstant('FORCE_ARRAY', new Literal('Nette\Utils\Json::FORCE_ARRAY'))
 	->addComment('Commented');
 
 $class->addConstant('MULTILINE_LONG', ['aaaaaaaa' => 1, 'bbbbbbbb' => 2, 'cccccccc' => 3, 'dddddddd' => 4, 'eeeeeeee' => 5, 'ffffffff' => 6]);
-$class->addConstant('SHORT', ['aaaaaaaa' => 1, 'bbbbbbbb' => 2, 'cccccccc' => 3, 'dddddddd' => 4, 'eeeeeeee' => 5, 'ffffffff' => 6]);
+$class->addConstant('SHORT', ['aaaaaaaa' => 1, 'bbbbbbbb' => 2, 'cccccccc' => 3, 'dddddddd' => 4, 'eeeeeeee' => 5]);
 
 $class->addProperty('handle')
 	->setVisibility('private')

tests/PhpGenerator/PsrPrinter.phpt

@@ -26,7 +26,7 @@ $class->addConstant('FORCE_ARRAY', new Literal('Nette\Utils\Json::FORCE_ARRAY'))
 	->addComment('Commented');
 
 $class->addConstant('MULTILINE_LONG', ['aaaaaaaa' => 1, 'bbbbbbbb' => 2, 'cccccccc' => 3, 'dddddddd' => 4, 'eeeeeeee' => 5, 'ffffffff' => 6]);
-$class->addConstant('SHORT', ['aaaaaaaa' => 1, 'bbbbbbbb' => 2, 'cccccccc' => 3, 'dddddddd' => 4, 'eeeeeeee' => 5, 'ffffffff' => 6]);
+$class->addConstant('SHORT', ['aaaaaaaa' => 1, 'bbbbbbbb' => 2, 'cccccccc' => 3, 'dddddddd' => 4, 'eeeeeeee' => 5]);
 
 $class->addProperty('handle')
 	->setVisibility('private')

tests/PhpGenerator/expected/ClassType.attributes.expect

@@ -9,7 +9,7 @@ class Example
 	/** Commented */
 	#[ExampleAttribute]
 	#[WithArguments(true)]
-	const FOO = 123;
+	public const FOO = 123;
 
 	/** @var resource */
 	#[ExampleAttribute]

tests/PhpGenerator/expected/ClassType.enum.expect

@@ -16,7 +16,7 @@ enum Suit
 	case Hearts;
 	case Spades;
 
-	const ACTIVE = false;
+	public const ACTIVE = false;
 
 	public function foo()
 	{

tests/PhpGenerator/expected/ClassType.expect

@@ -12,7 +12,7 @@ abstract class Example extends ParentClass implements IExample, IOne
 	}
 
 	const ROLE = 'admin';
-	final const ACTIVE = false;
+	final public const ACTIVE = false;
 
 	/** Commented */
 	private const FORCE_ARRAY = Nette\Utils\Json::FORCE_ARRAY;

tests/PhpGenerator/expected/Printer.class-alt.expect

@@ -12,7 +12,7 @@ final class Example extends ParentClass implements IExample
 	/** Commented */
 	private const FORCE_ARRAY = Nette\Utils\Json::FORCE_ARRAY;
 
-	const MULTILINE_LONG = [
+	public const MULTILINE_LONG = [
 		'aaaaaaaa' => 1,
 		'bbbbbbbb' => 2,
 		'cccccccc' => 3,
@@ -21,7 +21,7 @@ final class Example extends ParentClass implements IExample
 		'ffffffff' => 6,
 	];
 
-	const SHORT = ['aaaaaaaa' => 1, 'bbbbbbbb' => 2, 'cccccccc' => 3, 'dddddddd' => 4, 'eeeeeeee' => 5, 'ffffffff' => 6];
+	public const SHORT = ['aaaaaaaa' => 1, 'bbbbbbbb' => 2, 'cccccccc' => 3, 'dddddddd' => 4, 'eeeeeeee' => 5];
 
 	/** @var resource  orignal file handle */
 	private $handle;

tests/PhpGenerator/expected/Printer.class.expect

@@ -12,7 +12,7 @@ final class Example extends ParentClass implements IExample
 	/** Commented */
 	private const FORCE_ARRAY = Nette\Utils\Json::FORCE_ARRAY;
 
-	const MULTILINE_LONG = [
+	public const MULTILINE_LONG = [
 		'aaaaaaaa' => 1,
 		'bbbbbbbb' => 2,
 		'cccccccc' => 3,
@@ -21,7 +21,7 @@ final class Example extends ParentClass implements IExample
 		'ffffffff' => 6,
 	];
 
-	const SHORT = ['aaaaaaaa' => 1, 'bbbbbbbb' => 2, 'cccccccc' => 3, 'dddddddd' => 4, 'eeeeeeee' => 5, 'ffffffff' => 6];
+	public const SHORT = ['aaaaaaaa' => 1, 'bbbbbbbb' => 2, 'cccccccc' => 3, 'dddddddd' => 4, 'eeeeeeee' => 5];
 
 	/** @var resource  orignal file handle */
 	private $handle;

tests/PhpGenerator/expected/PsrPrinter.class.expect

@@ -12,7 +12,7 @@ final class Example extends ParentClass implements IExample
     /** Commented */
     private const FORCE_ARRAY = Nette\Utils\Json::FORCE_ARRAY;
 
-    const MULTILINE_LONG = [
+    public const MULTILINE_LONG = [
         'aaaaaaaa' => 1,
         'bbbbbbbb' => 2,
         'cccccccc' => 3,
@@ -21,7 +21,7 @@ final class Example extends ParentClass implements IExample
         'ffffffff' => 6,
     ];
 
-    const SHORT = ['aaaaaaaa' => 1, 'bbbbbbbb' => 2, 'cccccccc' => 3, 'dddddddd' => 4, 'eeeeeeee' => 5, 'ffffffff' => 6];
+    public const SHORT = ['aaaaaaaa' => 1, 'bbbbbbbb' => 2, 'cccccccc' => 3, 'dddddddd' => 4, 'eeeeeeee' => 5];
 
     /** @var resource  orignal file handle */
     private $handle;