added Modifier

Author: dg

readme.md

@@ -90,7 +90,7 @@ $class->addConstant('ID', 123)
 	->setFinal();
 
 $class->addProperty('items', [1, 2, 3])
-	->setPrivate() // or setVisibility('private')
+	->setPrivate() // or setVisibility(Nette\PhpGenerator\Modifier::Private)
 	->setStatic()
 	->addComment('@var int[]');
 

src/PhpGenerator/ClassLike.php

@@ -20,19 +20,23 @@ abstract class ClassLike
 	use Traits\CommentAware;
 	use Traits\AttributeAware;
 
-	public const
-		VisibilityPublic = 'public',
-		VisibilityProtected = 'protected',
-		VisibilityPrivate = 'private';
+	/** @deprecated use Modifier::Public */
+	public const VisibilityPublic = Modifier::Public;
 
-	/** @deprecated use ClassLike::VisibilityPublic */
-	public const VISIBILITY_PUBLIC = self::VisibilityPublic;
+	/** @deprecated use Modifier::Protected */
+	public const VisibilityProtected = Modifier::Protected;
 
-	/** @deprecated use ClassLike::VisibilityProtected */
-	public const VISIBILITY_PROTECTED = self::VisibilityProtected;
+	/** @deprecated use Modifier::Private */
+	public const VisibilityPrivate = Modifier::Private;
 
-	/** @deprecated use ClassLike::VisibilityPrivate */
-	public const VISIBILITY_PRIVATE = self::VisibilityPrivate;
+	/** @deprecated use Modifier::Public */
+	public const VISIBILITY_PUBLIC = Modifier::Public;
+
+	/** @deprecated use Modifier::Protected */
+	public const VISIBILITY_PROTECTED = Modifier::Protected;
+
+	/** @deprecated use Modifier::Private */
+	public const VISIBILITY_PRIVATE = Modifier::Private;
 
 	private ?PhpNamespace $namespace;
 	private ?string $name;

src/PhpGenerator/Extractor.php

@@ -483,9 +483,9 @@ private function toValue(Node\Expr $node): mixed
 	private function toVisibility(int $flags): ?string
 	{
 		return match (true) {
-			(bool) ($flags & Node\Stmt\Class_::MODIFIER_PUBLIC) => ClassType::VisibilityPublic,
-			(bool) ($flags & Node\Stmt\Class_::MODIFIER_PROTECTED) => ClassType::VisibilityProtected,
-			(bool) ($flags & Node\Stmt\Class_::MODIFIER_PRIVATE) => ClassType::VisibilityPrivate,
+			(bool) ($flags & Node\Stmt\Class_::MODIFIER_PUBLIC) => Modifier::Public,
+			(bool) ($flags & Node\Stmt\Class_::MODIFIER_PROTECTED) => Modifier::Protected,
+			(bool) ($flags & Node\Stmt\Class_::MODIFIER_PRIVATE) => Modifier::Private,
 			default => null,
 		};
 	}

src/PhpGenerator/Factory.php

@@ -307,8 +307,8 @@ private function getAttributes($from): array
 	private function getVisibility($from): string
 	{
 		return $from->isPrivate()
-			? ClassLike::VisibilityPrivate
-			: ($from->isProtected() ? ClassLike::VisibilityProtected : ClassLike::VisibilityPublic);
+			? Modifier::Private
+			: ($from->isProtected() ? Modifier::Protected : Modifier::Public);
 	}
 
 

src/PhpGenerator/Method.php

@@ -98,7 +98,7 @@ public function addPromotedParameter(string $name, mixed $defaultValue = null):
 	/** @throws Nette\InvalidStateException */
 	public function validate(): void
 	{
-		if ($this->abstract && ($this->final || $this->visibility === ClassLike::VisibilityPrivate)) {
+		if ($this->abstract && ($this->final || $this->visibility === Modifier::Private)) {
 			throw new Nette\InvalidStateException("Method $this->name() cannot be abstract and final or private at the same time.");
 		}
 	}

src/PhpGenerator/Modifier.php

@@ -0,0 +1,25 @@
+<?php
+
+/**
+ * This file is part of the Nette Framework (https://nette.org)
+ * Copyright (c) 2004 David Grudl (https://davidgrudl.com)
+ */
+
+declare(strict_types=1);
+
+namespace Nette\PhpGenerator;
+
+use Nette;
+
+
+/**
+ * Class members modifiers.
+ */
+final class Modifier
+{
+	use Nette\StaticClass;
+
+	public const Public = 'public';
+	public const Protected = 'protected';
+	public const Private = 'private';
+}

src/PhpGenerator/Traits/VisibilityAware.php

@@ -10,7 +10,7 @@
 namespace Nette\PhpGenerator\Traits;
 
 use Nette;
-use Nette\PhpGenerator\ClassLike;
+use Nette\PhpGenerator\Modifier;
 
 
 /**
@@ -27,7 +27,7 @@ trait VisibilityAware
 	 */
 	public function setVisibility(?string $val): static
 	{
-		if (!in_array($val, [ClassLike::VisibilityPublic, ClassLike::VisibilityProtected, ClassLike::VisibilityPrivate, null], true)) {
+		if (!in_array($val, [Modifier::Public, Modifier::Protected, Modifier::Private, null], true)) {
 			throw new Nette\InvalidArgumentException('Argument must be public|protected|private.');
 		}
 
@@ -44,39 +44,39 @@ public function getVisibility(): ?string
 
 	public function setPublic(): static
 	{
-		$this->visibility = ClassLike::VisibilityPublic;
+		$this->visibility = Modifier::Public;
 		return $this;
 	}
 
 
 	public function isPublic(): bool
 	{
-		return $this->visibility === ClassLike::VisibilityPublic || $this->visibility === null;
+		return $this->visibility === Modifier::Public || $this->visibility === null;
 	}
 
 
 	public function setProtected(): static
 	{
-		$this->visibility = ClassLike::VisibilityProtected;
+		$this->visibility = Modifier::Protected;
 		return $this;
 	}
 
 
 	public function isProtected(): bool
 	{
-		return $this->visibility === ClassLike::VisibilityProtected;
+		return $this->visibility === Modifier::Protected;
 	}
 
 
 	public function setPrivate(): static
 	{
-		$this->visibility = ClassLike::VisibilityPrivate;
+		$this->visibility = Modifier::Private;
 		return $this;
 	}
 
 
 	public function isPrivate(): bool
 	{
-		return $this->visibility === ClassLike::VisibilityPrivate;
+		return $this->visibility === Modifier::Private;
 	}
 }