setName() is deprecated in favor of constructors

Author: dg

src/PhpGenerator/ClassType.php

@@ -99,9 +99,9 @@ public static function from($from)
 	}
 
 
-	public function __construct($name = NULL, PhpNamespace $namespace = NULL)
+	public function __construct($name = '', PhpNamespace $namespace = NULL)
 	{
-		$this->setName((string) $name);
+		$this->setName($name);
 		$this->namespace = $namespace;
 	}
 
@@ -158,18 +158,15 @@ public function __toString()
 
 
 	/**
-	 * @return PhpNamespace
+	 * @return PhpNamespace|NULL
 	 */
 	public function getNamespace()
 	{
 		return $this->namespace;
 	}
 
 
-	/**
-	 * @param  string
-	 * @return self
-	 */
+	/** @deprecated */
 	public function setName($name)
 	{
 		$this->name = (string) $name;

src/PhpGenerator/Method.php

@@ -141,10 +141,7 @@ public function __toString()
 	}
 
 
-	/**
-	 * @param  string|NULL
-	 * @return self
-	 */
+	/** @deprecated */
 	public function setName($name)
 	{
 		$this->name = $name ? (string) $name : NULL;

src/PhpGenerator/Parameter.php

@@ -75,10 +75,7 @@ public function __construct($name = '')
 	}
 
 
-	/**
-	 * @param  string  without $
-	 * @return self
-	 */
+	/** @deprecated */
 	public function setName($name)
 	{
 		$this->name = (string) $name;

src/PhpGenerator/PhpNamespace.php

@@ -41,10 +41,7 @@ public function __construct($name = NULL)
 	}
 
 
-	/**
-	 * @param  string|NULL
-	 * @return self
-	 */
+	/** @deprecated */
 	public function setName($name)
 	{
 		$this->name = (string) $name;

src/PhpGenerator/Property.php

@@ -55,10 +55,7 @@ public function __construct($name = '')
 	}
 
 
-	/**
-	 * @param  string  without $
-	 * @return self
-	 */
+	/** @deprecated */
 	public function setName($name)
 	{
 		$this->name = (string) $name;

tests/PhpGenerator/Method.returnTypes.phpt

@@ -34,8 +34,7 @@ namespace
 
 	// generating methods with return type declarations
 
-	$method = (new Method)
-		->setName('create')
+	$method = (new Method('create'))
 		->setReturnType('Foo')
 		->setBody('return new Foo();');
 

tests/PhpGenerator/Method.scalarParameters.phpt

@@ -35,8 +35,7 @@ Assert::same('float', $method->getParameters()['d']->getTypeHint());
 
 // generating methods with scalar type hints
 
-$method = (new Method)
-	->setName('create')
+$method = (new Method('create'))
 	->setBody('return null;');
 $method->addParameter('a')->setTypeHint('string');
 $method->addParameter('b')->setTypeHint('bool');

tests/PhpGenerator/Method.variadics.phpt

@@ -34,8 +34,7 @@ Assert::same('array', $method->getParameters()['bar']->getTypeHint());
 // test generating
 
 // parameterless variadic method
-$method = (new Method)
-	->setName('variadic')
+$method = (new Method('variadic'))
 	->setVariadic(TRUE)
 	->setBody('return 42;');
 
@@ -48,8 +47,7 @@ Assert::match(
 
 
 // variadic method with one parameter
-$method = (new Method)
-	->setName('variadic')
+$method = (new Method('variadic'))
 	->setVariadic(TRUE)
 	->setBody('return 42;');
 $method->addParameter('foo');
@@ -63,8 +61,7 @@ Assert::match(
 
 
 // variadic method with multiple parameters
-$method = (new Method)
-	->setName('variadic')
+$method = (new Method('variadic'))
 	->setVariadic(TRUE)
 	->setBody('return 42;');
 $method->addParameter('foo');
@@ -80,8 +77,7 @@ Assert::match(
 
 
 // method with typehinted variadic param
-$method = (new Method)
-	->setName('variadic')
+$method = (new Method('variadic'))
 	->setVariadic(TRUE)
 	->setBody('return 42;');
 $method->addParameter('foo')->setTypeHint('array');
@@ -95,8 +91,7 @@ Assert::match(
 
 
 // method with typrhinted by-value variadic param
-$method = (new Method)
-	->setName('variadic')
+$method = (new Method('variadic'))
 	->setVariadic(TRUE)
 	->setBody('return 42;');
 $method->addParameter('foo')->setTypeHint('array')->setReference(TRUE);