Parameter::from() prevents fatal error when default value is not resolvable

Author: dg

src/PhpGenerator/Parameter.php

@@ -59,9 +59,13 @@ public static function from(\ReflectionParameter $from)
 				}
 			}
 		}
-		$param->hasDefaultValue = $from->isDefaultValueAvailable();
-		$param->defaultValue = $from->isDefaultValueAvailable() ? $from->getDefaultValue() : NULL;
-		$param->nullable = $param->nullable && (!$param->hasDefaultValue || $param->defaultValue !== NULL);
+		if ($from->isDefaultValueAvailable()) {
+			$param->hasDefaultValue = TRUE;
+			$param->defaultValue = $from->isDefaultValueConstant()
+				? new PhpLiteral($from->getDefaultValueConstantName())
+				: $from->getDefaultValue();
+			$param->nullable = $param->nullable && $param->defaultValue !== NULL;
+		}
 		return $param;
 	}
 

tests/PhpGenerator/ClassType.from.expect

@@ -48,7 +48,7 @@ class Class2 extends Class1 implements Interface2
 	 * Func3
 	 * @return Class1
 	 */
-	private function &func3(array $a%a?%, Class2 $b = NULL, Unknown $c, \Xyz\Unknown $d, callable $e, $f)
+	private function &func3(array $a%a?%, Class2 $b = NULL, Unknown $c, \Xyz\Unknown $d, callable $e, $f = Abc\Unknown::ABC, $g)
 	{
 	}
 

tests/PhpGenerator/ClassType.from.phpt

@@ -54,7 +54,7 @@ class Class2 extends Class1 implements Interface2
 	 * Func3
 	 * @return Class1
 	 */
-	private function &func3(array $a = [], Class2 $b = NULL, \Abc\Unknown $c, \Xyz\Unknown $d, callable $e, $f)
+	private function &func3(array $a = [], Class2 $b = NULL, \Abc\Unknown $c, \Xyz\Unknown $d, callable $e, $f = Unknown::ABC, $g)
 	{}
 
 	final function func2()