PhpNamespace::addUse() added validation

Author: dg

src/PhpGenerator/PhpNamespace.php

@@ -87,6 +87,15 @@ public function getBracketedSyntax(): bool
 	 */
 	public function addUse(string $name, string $alias = null, string &$aliasOut = null): self
 	{
+		if (
+			!Helpers::isNamespaceIdentifier($name, true)
+			|| (Helpers::isIdentifier($name) && isset(Helpers::KEYWORDS[strtolower($name)]))
+		) {
+			throw new Nette\InvalidArgumentException("Value '$name' is not valid class name.");
+		} elseif ($alias && (!Helpers::isIdentifier($alias) || isset(Helpers::KEYWORDS[strtolower($alias)]))) {
+			throw new Nette\InvalidArgumentException("Value '$alias' is not valid alias.");
+		}
+
 		$name = ltrim($name, '\\');
 		if ($alias === null && $this->name === Helpers::extractNamespace($name)) {
 			$alias = Helpers::extractShortName($name);

tests/PhpGenerator/invalidNames.phpt

@@ -36,6 +36,22 @@ Assert::exception(function () {
 	new Nette\PhpGenerator\PhpNamespace('\abc');
 }, Nette\InvalidArgumentException::class);
 
+Assert::exception(function () {
+	(new Nette\PhpGenerator\PhpNamespace('Abc'))->addUse('');
+}, Nette\InvalidArgumentException::class);
+
+Assert::exception(function () {
+	(new Nette\PhpGenerator\PhpNamespace('Abc'))->addUse('Foo', 'a b');
+}, Nette\InvalidArgumentException::class);
+
+Assert::exception(function () {
+	(new Nette\PhpGenerator\PhpNamespace('Abc'))->addUse('true');
+}, Nette\InvalidArgumentException::class);
+
+Assert::exception(function () {
+	(new Nette\PhpGenerator\PhpNamespace('Abc'))->addUse('aaa', 'true');
+}, Nette\InvalidArgumentException::class);
+
 
 Assert::noError(function () {
 	new Nette\PhpGenerator\ClassType(null); // anonymous class