new deprecated stuff triggers warnings (BC break)

Author: dg

src/PhpGenerator/ClassType.php

@@ -68,6 +68,9 @@ class ClassType
 	 */
 	public static function from($class)
 	{
+		if ($class instanceof \ReflectionClass) {
+			trigger_error(__METHOD__ . '() accepts only class name or object.', E_USER_DEPRECATED);
+		}
 		return (new Factory)->fromClassReflection(
 			$class instanceof \ReflectionClass ? $class : new \ReflectionClass($class)
 		);
@@ -330,6 +333,7 @@ public function addTrait($trait, array $resolutions = [])
 	 */
 	public function setConsts(array $consts)
 	{
+		trigger_error(__METHOD__ . '() is deprecated, use setConstants()', E_USER_DEPRECATED);
 		return $this->setConstants($consts);
 	}
 
@@ -340,6 +344,7 @@ public function setConsts(array $consts)
 	 */
 	public function getConsts()
 	{
+		trigger_error(__METHOD__ . '() is deprecated, use similar getConstants()', E_USER_DEPRECATED);
 		return array_map(function ($const) { return $const->getValue(); }, $this->consts);
 	}
 
@@ -352,6 +357,7 @@ public function getConsts()
 	 */
 	public function addConst($name, $value)
 	{
+		trigger_error(__METHOD__ . '() is deprecated, use similar addConstant()', E_USER_DEPRECATED);
 		$this->addConstant($name, $value);
 		return $this;
 	}

src/PhpGenerator/Method.php

@@ -41,7 +41,11 @@ class Method
 	 */
 	public static function from($method)
 	{
-		$method = $method instanceof \ReflectionMethod ? $method : Nette\Utils\Callback::toReflection($method);
+		if ($method instanceof \ReflectionMethod) {
+			trigger_error(__METHOD__ . '() accepts only method name.', E_USER_DEPRECATED);
+		} else {
+			$method = Nette\Utils\Callback::toReflection($method);
+		}
 		return (new Factory)->fromMethodReflection($method);
 	}
 

src/PhpGenerator/PhpNamespace.php

@@ -59,6 +59,7 @@ public function __construct($name = NULL)
 	/** @deprecated */
 	public function setName($name)
 	{
+		trigger_error(__METHOD__ . '() is deprecated, use constructor.', E_USER_DEPRECATED);
 		$this->__construct($name);
 		return $this;
 	}

tests/PhpGenerator/ClassType.from.phpt

@@ -9,6 +9,7 @@ declare(strict_types=1);
 namespace Abc;
 
 use Nette\PhpGenerator\ClassType;
+use Nette\PhpGenerator\Factory;
 use Tester\Assert;
 
 
@@ -71,9 +72,9 @@ class Class3
 $res[] = ClassType::from(Interface1::class);
 $res[] = ClassType::from(Interface2::class);
 $res[] = ClassType::from(Class1::class);
-$res[] = ClassType::from(new \ReflectionClass(Class2::class));
+$res[] = ClassType::from(new Class2);
 $obj = new Class3;
 $obj->prop2 = 1;
-$res[] = ClassType::from(new \ReflectionObject($obj));
+$res[] = (new Factory)->fromClassReflection(new \ReflectionObject($obj));
 
 Assert::matchFile(__DIR__ . '/ClassType.from.expect', implode("\n", $res));

tests/PhpGenerator/ClassType.from.trait.phpt

@@ -38,9 +38,9 @@ class Class2 extends Class1
 {
 }
 
-$res[] = ClassType::from(new ReflectionClass('Trait1'));
-$res[] = ClassType::from(new ReflectionClass('Trait2'));
-$res[] = ClassType::from(new ReflectionClass('Class1'));
-$res[] = ClassType::from(new ReflectionClass('Class2'));
+$res[] = ClassType::from('Trait1');
+$res[] = ClassType::from('Trait2');
+$res[] = ClassType::from('Class1');
+$res[] = ClassType::from('Class2');
 
 Assert::matchFile(__DIR__ . '/ClassType.from.trait.expect', implode("\n", $res));

tests/PhpGenerator/ClassType.phpt

@@ -25,10 +25,8 @@ $class
 	->addTrait('AnotherTrait', ['sayHello as protected'])
 	->addComment("Description of class.\nThis is example\n")
 	->addComment('@property-read Nette\Forms\Form $form')
-	->setConsts(['ROLE' => 'admin'])
-	->addConst('ACTIVE', FALSE);
-
-Assert::same(['ROLE' => 'admin', 'ACTIVE' => FALSE], $class->getConsts());
+	->setConstants(['ROLE' => 'admin'])
+	->addConstant('ACTIVE', FALSE);
 
 $class->addConstant('FORCE_ARRAY', new PhpLiteral('Nette\Utils\Json::FORCE_ARRAY'))
 	->setVisibility('private')