Skip to content

Commit b3908c6

Browse files
xpavp03dg
authored andcommitted
PhpGenerator, tests: fixed bug in dumping associative arrays with numerical keys that are out of order
1 parent e5ac6af commit b3908c6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/PhpGenerator/Helpers.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ private static function _dump(&$var, $level = 0)
8585
foreach ($var as $k => &$v) {
8686
if ($k !== $marker) {
8787
$s .= "$space\t" . ($k === $counter ? '' : self::_dump($k) . " => ") . self::_dump($v, $level + 1) . ",\n";
88-
$counter = is_int($k) ? $k + 1 : $counter;
88+
$counter = is_int($k) ? max($k + 1, $counter) : $counter;
8989
}
9090
}
9191
unset($var[$marker]);

tests/PhpGenerator/PhpGenerator.dump.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Assert::same( 'array()', Helpers::dump(array()) );
3939
Assert::same( "array(\n\t\$s,\n)", Helpers::dump(array(new PhpLiteral('$s'))) );
4040

4141
Assert::same( "array(\n\t1,\n\t2,\n\t3,\n)", Helpers::dump(array(1,2,3)) );
42-
Assert::same( "array(\n\t'a',\n\t7 => 'b',\n\t'c',\n\t'9a' => 'd',\n\t'e',\n)", Helpers::dump(array('a', 7 => 'b', 'c', '9a' => 'd', 'e')) );
42+
Assert::same( "array(\n\t'a',\n\t7 => 'b',\n\t'c',\n\t'9a' => 'd',\n\t'e',\n)", Helpers::dump(array('a', 7 => 'b', 'c', '9a' => 'd', 9 => 'e')) );
4343
Assert::same( "array(\n\t'a' => 1,\n\tarray(\n\t\t\"\\r\" => \"\\r\",\n\t\t2,\n\t),\n\t3,\n)", Helpers::dump(array('a' => 1, array("\r" => "\r", 2), 3)) );
4444

4545
Assert::same( "(object) array(\n\t'a' => 1,\n\t'b' => 2,\n)", Helpers::dump((object) array('a' => 1, 'b' => 2)) );

0 commit comments

Comments
 (0)