Skip to content

Commit c182b96

Browse files
committed
PhpNamespace::__construct() $name is mandatory, setName() triggers warnings (BC break)
1 parent ca0ca86 commit c182b96

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/PhpGenerator/PhpNamespace.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class PhpNamespace
4747
/**
4848
* @param string|NULL
4949
*/
50-
public function __construct($name = NULL)
50+
public function __construct($name)
5151
{
5252
if ($name && !Helpers::isNamespace($name)) {
5353
throw new Nette\InvalidArgumentException("Value '$name' is not valid name.");

tests/PhpGenerator/PhpNamespace.fqn.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Assert::matchFile(__DIR__ . '/PhpNamespace.fqn1.expect', (string) $class);
3838

3939

4040
// global namespace
41-
$class = new ClassType('Example', new PhpNamespace);
41+
$class = new ClassType('Example', new PhpNamespace(''));
4242
$class
4343
->setExtends('\ParentClass')
4444
->addImplement('One')

tests/PhpGenerator/PhpNamespace.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ use Tester\Assert;
1212
require __DIR__ . '/../bootstrap.php';
1313

1414

15-
$namespace = new PhpNamespace;
15+
$namespace = new PhpNamespace('');
1616

1717
Assert::same('A', $namespace->unresolveName('A'));
1818
Assert::same('foo\A', $namespace->unresolveName('foo\A'));

0 commit comments

Comments
 (0)