Helpers::formatArgs() escaped \? means ? (possible BC break)

Author: dg

src/PhpGenerator/Helpers.php

@@ -162,11 +162,13 @@ public static function format(string $statement, ...$args): string
 	 */
 	public static function formatArgs(string $statement, array $args): string
 	{
-		$tokens = preg_split('#(\.\.\.\?|\$\?|->\?|::\?|\?\*|\?)#', $statement, -1, PREG_SPLIT_DELIM_CAPTURE);
+		$tokens = preg_split('#(\.\.\.\?|\$\?|->\?|::\?|\\\\\?|\?\*|\?)#', $statement, -1, PREG_SPLIT_DELIM_CAPTURE);
 		$res = '';
 		foreach ($tokens as $n => $token) {
 			if ($n % 2 === 0) {
 				$res .= $token;
+			} elseif ($token === '\\?') {
+				$res .= '?';
 			} elseif (!$args) {
 				throw new Nette\InvalidArgumentException('Insufficient number of arguments.');
 			} elseif ($token === '?') {

tests/PhpGenerator/Helpers.format.phpt

@@ -17,6 +17,7 @@ Assert::same('func', Helpers::format('func'));
 Assert::same('func(1)', Helpers::format('func(?)', 1));
 Assert::same('func', Helpers::formatArgs('func', []));
 Assert::same('func(1)', Helpers::formatArgs('func(?)', [1]));
+Assert::same('func(1 ? 2 : 3)', Helpers::formatArgs('func(1 \? 2 : 3)', []));
 Assert::same('func([1, 2])', Helpers::formatArgs('func(?)', [[1, 2]]));
 Assert::same('func(1, 2)', Helpers::formatArgs('func(...?)', [[1, 2]]));
 Assert::same('func(1, 2)', Helpers::formatArgs('func(?*)', [[1, 2]])); // old way