PhpFile: bracketed syntax is normalized when namespace is added

dg · dg · commit d00eaff69349 · 2018-08-29T19:24:49.000+02:00
diff --git a/src/PhpGenerator/PhpFile.php b/src/PhpGenerator/PhpFile.php
@@ -58,6 +58,9 @@ public function addNamespace(string $name): PhpNamespace
 	{
 		if (!isset($this->namespaces[$name])) {
 			$this->namespaces[$name] = new PhpNamespace($name);
+			foreach ($this->namespaces as $namespace) {
+				$namespace->setBracketedSyntax(count($this->namespaces) > 1 && isset($this->namespaces['']));
+			}
 		}
 		return $this->namespaces[$name];
 	}
@@ -74,10 +77,6 @@ public function getNamespaces(): array
 
 	public function __toString(): string
 	{
-		foreach ($this->namespaces as $namespace) {
-			$namespace->setBracketedSyntax(count($this->namespaces) > 1 && isset($this->namespaces['']));
-		}
-
 		return Strings::normalize(
 			"<?php\n"
 			. ($this->comment ? "\n" . Helpers::formatDocComment($this->comment . "\n") . "\n" : '')

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,9 @@ public function addNamespace(string $name): PhpNamespace`
`58`	`58`	`{`
`59`	`59`	`if (!isset($this->namespaces[$name])) {`
`60`	`60`	`$this->namespaces[$name] = new PhpNamespace($name);`
	`61`	`+ foreach ($this->namespaces as $namespace) {`
	`62`	`+ $namespace->setBracketedSyntax(count($this->namespaces) > 1 && isset($this->namespaces['']));`
	`63`	`+ }`
`61`	`64`	`}`
`62`	`65`	`return $this->namespaces[$name];`
`63`	`66`	`}`
`@@ -74,10 +77,6 @@ public function getNamespaces(): array`
`74`	`77`
`75`	`78`	`public function __toString(): string`
`76`	`79`	`{`
`77`		`- foreach ($this->namespaces as $namespace) {`
`78`		`- $namespace->setBracketedSyntax(count($this->namespaces) > 1 && isset($this->namespaces['']));`
`79`		`- }`
`80`		`-`
`81`	`80`	`return Strings::normalize(`
`82`	`81`	`"<?php\n"`
`83`	`82`	`. ($this->comment ? "\n" . Helpers::formatDocComment($this->comment . "\n") . "\n" : '')`