Skip to content

Commit d0fa50b

Browse files
committed
PhpNamespace::addClass() triggers notice when class was already added (BC break)
1 parent e8bc0e8 commit d0fa50b

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/PhpGenerator/PhpNamespace.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,11 +155,12 @@ public function unresolveName(string $name): string
155155

156156
public function addClass(string $name): ClassType
157157
{
158-
if (!isset($this->classes[$name])) {
159-
$this->addUse($this->name . '\\' . $name);
160-
$this->classes[$name] = new ClassType($name, $this);
158+
if (isset($this->classes[$name])) {
159+
trigger_error(__METHOD__ . "() class $name was already added.", E_USER_DEPRECATED);
160+
return $this->classes[$name];
161161
}
162-
return $this->classes[$name];
162+
$this->addUse($this->name . '\\' . $name);
163+
return $this->classes[$name] = new ClassType($name, $this);
163164
}
164165

165166

0 commit comments

Comments
 (0)