Constant: type can be nullable

dg · dg · commit e45595f25438 · 2024-11-28T20:12:22.000+01:00
diff --git a/src/PhpGenerator/Constant.php b/src/PhpGenerator/Constant.php
@@ -53,7 +53,8 @@ public function isFinal(): bool
 
 	public function setType(?string $type): static
 	{
-		$this->type = Helpers::validateType($type);
+		Helpers::validateType($type);
+		$this->type = $type;
 		return $this;
 	}
 
diff --git a/tests/PhpGenerator/ClassType.phpt b/tests/PhpGenerator/ClassType.phpt
@@ -39,7 +39,7 @@ $trait2 = $class->addTrait('AnotherTrait')
 $class->addConstant('ROLE', 'admin');
 $class->addConstant('ACTIVE', false)
 	->setFinal()
-	->setType('bool');
+	->setType('?bool');
 Assert::true($class->hasConstant('ROLE'));
 Assert::false($class->hasConstant('xxx'));
 
diff --git a/tests/PhpGenerator/expected/ClassType.expect b/tests/PhpGenerator/expected/ClassType.expect
@@ -17,7 +17,7 @@ abstract class Example extends ParentClass implements IExample, IOne
 	}
 
 	public const ROLE = 'admin';
-	final public const bool ACTIVE = false;
+	final public const ?bool ACTIVE = false;
 
 	/** Commented */
 	private const FORCE_ARRAY = Nette\Utils\Json::FORCE_ARRAY;

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,8 @@ public function isFinal(): bool`
`53`	`53`
`54`	`54`	`public function setType(?string $type): static`
`55`	`55`	`{`
`56`		`- $this->type = Helpers::validateType($type);`
	`56`	`+ Helpers::validateType($type);`
	`57`	`+ $this->type = $type;`
`57`	`58`	`return $this;`
`58`	`59`	`}`
`59`	`60`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ abstract class Example extends ParentClass implements IExample, IOne`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`public const ROLE = 'admin';`
`20`		`- final public const bool ACTIVE = false;`
	`20`	`+ final public const ?bool ACTIVE = false;`
`21`	`21`
`22`	`22`	`/** Commented */`
`23`	`23`	`private const FORCE_ARRAY = Nette\Utils\Json::FORCE_ARRAY;`