Revert "saveCache() is atomic [Closes #11]"

dg · dg · commit 01c0c643ba89 · 2020-02-12T12:55:53.000+01:00
This reverts commit b703b4f.
diff --git a/src/RobotLoader/RobotLoader.php b/src/RobotLoader/RobotLoader.php
@@ -438,10 +438,9 @@ private function loadCache(): void
 	private function saveCache(): void
 	{
 		$file = $this->getCacheFile();
-		$tempFile = $file . uniqid('', true) . '.tmp';
 		$code = "<?php\nreturn " . var_export([$this->classes, $this->missing], true) . ";\n";
-		if (file_put_contents($tempFile, $code) !== strlen($code) || !rename($tempFile, $file)) {
-			@unlink($tempFile); // @ - file may not exist
+		if (file_put_contents("$file.tmp", $code) !== strlen($code) || !rename("$file.tmp", $file)) {
+			@unlink("$file.tmp"); // @ - file may not exist
 			throw new \RuntimeException("Unable to create '$file'.");
 		}
 		if (function_exists('opcache_invalidate')) {

Original file line number	Diff line number	Diff line change
`@@ -438,10 +438,9 @@ private function loadCache(): void`
`438`	`438`	`private function saveCache(): void`
`439`	`439`	`{`
`440`	`440`	`$file = $this->getCacheFile();`
`441`		`- $tempFile = $file . uniqid('', true) . '.tmp';`
`442`	`441`	`$code = "<?php\nreturn " . var_export([$this->classes, $this->missing], true) . ";\n";`
`443`		`- if (file_put_contents($tempFile, $code) !== strlen($code) \|\| !rename($tempFile, $file)) {`
`444`		`- @unlink($tempFile); // @ - file may not exist`
	`442`	`+ if (file_put_contents("$file.tmp", $code) !== strlen($code) \|\| !rename("$file.tmp", $file)) {`
	`443`	`+ @unlink("$file.tmp"); // @ - file may not exist`
`445`	`444`	`throw new \RuntimeException("Unable to create '$file'.");`
`446`	`445`	`}`
`447`	`446`	`if (function_exists('opcache_invalidate')) {`