added setTempDirectory(), should be used instead of setCacheStorage()

Author: dg

readme.md

@@ -34,7 +34,7 @@ $loader = new Nette\Loaders\RobotLoader;
 $loader->addDirectory('app');
 $loader->addDirectory('libs');
 // And set caching to the 'temp' directory on the disc
-$loader->setCacheStorage(new Nette\Caching\Storages\FileStorage('temp'));
+$loader->setTempDirectory('temp');
 $loader->register(); // Run the RobotLoader
 ```
 

src/RobotLoader/RobotLoader.php

@@ -346,6 +346,24 @@ public function setAutoRefresh($on = TRUE)
 	}
 
 
+	/**
+	 * Sets path to temporary directory.
+	 * @return static
+	 */
+	public function setTempDirectory($dir)
+	{
+		if ($dir) {
+			if (!is_dir($dir)) {
+				@mkdir($dir); // @ - directory may already exist
+			}
+			$this->cacheStorage = new Nette\Caching\Storages\FileStorage($dir);
+		} else {
+			$this->cacheStorage = new Nette\Caching\Storages\DevNullStorage;
+		}
+		return $this;
+	}
+
+
 	/**
 	 * @return static
 	 */
@@ -371,7 +389,7 @@ public function getCacheStorage()
 	protected function getCache()
 	{
 		if (!$this->cacheStorage) {
-			trigger_error('Missing cache storage.', E_USER_WARNING);
+			trigger_error('Set path to temporary directory using setTempDirectory().', E_USER_WARNING);
 			$this->cacheStorage = new Nette\Caching\Storages\DevNullStorage;
 		}
 		return new Cache($this->cacheStorage, 'Nette.RobotLoader');

tests/Loaders/RobotLoader.caseSensitivity.phpt

@@ -5,15 +5,14 @@
  */
 
 use Nette\Loaders\RobotLoader;
-use Nette\Caching\Storages\DevNullStorage;
 use Tester\Assert;
 
 
 require __DIR__ . '/../bootstrap.php';
 
 
 $loader = new RobotLoader;
-$loader->setCacheStorage(new DevNullStorage);
+$loader->setTempDirectory(TEMP_DIR);
 $loader->addDirectory(__DIR__ . '/files');
 $loader->register();
 

tests/Loaders/RobotLoader.phar.phpt

@@ -7,7 +7,6 @@
  */
 
 use Nette\Loaders\RobotLoader;
-use Nette\Caching\Storages\DevNullStorage;
 use Tester\Assert;
 
 
@@ -29,7 +28,7 @@ Phar::loadPhar($pharFile, 'test.phar');
 
 
 $loader = new RobotLoader;
-$loader->setCacheStorage(new DevNullStorage);
+$loader->setTempDirectory(TEMP_DIR);
 $loader->addDirectory("phar://$pharFile/sub");
 $loader->addDirectory("PHAR://$pharFile/class.B.php");
 $loader->addDirectory('phar://test.phar/class.C.php');
@@ -42,15 +41,15 @@ Assert::true(class_exists('D'));
 
 
 $loader = new RobotLoader;
-$loader->setCacheStorage(new DevNullStorage);
+$loader->setTempDirectory(TEMP_DIR);
 $loader->addDirectory("phar://$pharFile/non-dir");
 Assert::exception(function () use ($loader, $pharFile) {
 	$loader->register();
 }, Nette\IOException::class, "File or directory 'phar://$pharFile/non-dir' not found.");
 
 
 $loader = new RobotLoader;
-$loader->setCacheStorage(new DevNullStorage);
+$loader->setTempDirectory(TEMP_DIR);
 $loader->addDirectory("phar://$pharFile/non-file.php");
 Assert::exception(function () use ($loader, $pharFile) {
 	$loader->register();

tests/Loaders/RobotLoader.phpt

@@ -5,15 +5,14 @@
  */
 
 use Nette\Loaders\RobotLoader;
-use Nette\Caching\Storages\DevNullStorage;
 use Tester\Assert;
 
 
 require __DIR__ . '/../bootstrap.php';
 
 
 $loader = new RobotLoader;
-$loader->setCacheStorage(new DevNullStorage);
+$loader->setTempDirectory(TEMP_DIR);
 $loader->addDirectory(__DIR__ . '/files');
 $loader->addDirectory(__DIR__ . '/files/'); // purposely doubled
 $loader->addDirectory(__DIR__ . '/file/interface.php'); // as file

tests/Loaders/RobotLoader.rebuild.phpt

@@ -5,7 +5,6 @@
  */
 
 use Nette\Loaders\RobotLoader;
-use Nette\Caching\Storages\FileStorage;
 use Tester\Assert;
 
 
@@ -16,7 +15,7 @@ file_put_contents(TEMP_DIR . '/file1.php', '<?php class A {}');
 file_put_contents(TEMP_DIR . '/file2.php', '<?php class B {}');
 
 $loader = new RobotLoader;
-$loader->setCacheStorage(new FileStorage(TEMP_DIR));
+$loader->setTempDirectory(TEMP_DIR);
 $loader->addDirectory(TEMP_DIR);
 $loader->register(); // rebuilds cache
 
@@ -26,7 +25,7 @@ Assert::false(class_exists('A'));
 
 
 $loader2 = new RobotLoader;
-$loader2->setCacheStorage(new FileStorage(TEMP_DIR));
+$loader2->setTempDirectory(TEMP_DIR);
 $loader2->addDirectory(TEMP_DIR);
 $loader2->register();
 

tests/Loaders/RobotLoader.renamed.phpt

@@ -5,15 +5,14 @@
  */
 
 use Nette\Loaders\RobotLoader;
-use Nette\Caching\Storages\DevNullStorage;
 use Tester\Assert;
 
 
 require __DIR__ . '/../bootstrap.php';
 
 
 $loader = new RobotLoader;
-$loader->setCacheStorage(new DevNullStorage);
+$loader->setTempDirectory(TEMP_DIR);
 $loader->addDirectory(TEMP_DIR);
 
 $dir = TEMP_DIR . DIRECTORY_SEPARATOR;