Skip to content

Commit 8c932ae

Browse files
committed
improved coding style
1 parent 50d3095 commit 8c932ae

File tree

4 files changed

+38
-34
lines changed

4 files changed

+38
-34
lines changed

src/RobotLoader/RobotLoader.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77

88
namespace Nette\Loaders;
99

10-
use Nette,
11-
Nette\Caching\Cache;
10+
use Nette;
11+
use Nette\Caching\Cache;
1212

1313

1414
/**
@@ -51,7 +51,7 @@ class RobotLoader extends Nette\Object
5151
public function __construct()
5252
{
5353
if (!extension_loaded('tokenizer')) {
54-
throw new Nette\NotSupportedException("PHP extension Tokenizer is not loaded.");
54+
throw new Nette\NotSupportedException('PHP extension Tokenizer is not loaded.');
5555
}
5656
}
5757

@@ -101,7 +101,7 @@ public function tryLoad($type)
101101
}
102102

103103
if (isset($this->classes[$type]['file'])) {
104-
call_user_func(function($file) { require $file; }, $this->classes[$type]['file']);
104+
call_user_func(function ($file) { require $file; }, $this->classes[$type]['file']);
105105
} else {
106106
$this->missing[$type] = TRUE;
107107
}
@@ -211,12 +211,12 @@ private function createFileIterator($dir)
211211
}
212212

213213
$iterator = Nette\Utils\Finder::findFiles(is_array($this->acceptFiles) ? $this->acceptFiles : preg_split('#[,\s]+#', $this->acceptFiles))
214-
->filter(function($file) use (& $disallow) {
214+
->filter(function ($file) use (& $disallow) {
215215
return !isset($disallow[$file->getPathname()]);
216216
})
217217
->from($dir)
218218
->exclude($ignoreDirs)
219-
->filter($filter = function($dir) use (& $disallow) {
219+
->filter($filter = function ($dir) use (& $disallow) {
220220
$path = $dir->getPathname();
221221
if (is_file("$path/netterobots.txt")) {
222222
foreach (file("$path/netterobots.txt") as $s) {

tests/Loaders/RobotLoader.phpt

Lines changed: 25 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
* Test: Nette\Loaders\RobotLoader basic usage.
55
*/
66

7-
use Nette\Loaders\RobotLoader,
8-
Nette\Caching\Storages\DevNullStorage,
9-
Tester\Assert;
7+
use Nette\Loaders\RobotLoader;
8+
use Nette\Caching\Storages\DevNullStorage;
9+
use Tester\Assert;
1010

1111

1212
require __DIR__ . '/../bootstrap.php';
@@ -18,24 +18,28 @@ $loader->addDirectory(__DIR__ . '/files');
1818
$loader->addDirectory(__DIR__ . '/files/'); // purposely doubled
1919
$loader->addDirectory(__DIR__ . '/file/interface.php'); // as file
2020
$loader->addDirectory(__DIR__ . '/file/class.const.php');
21-
if (PHP_VERSION_ID >= 50400) $loader->addDirectory(__DIR__ . '/file/trait.php');
21+
if (PHP_VERSION_ID >= 50400) {
22+
$loader->addDirectory(__DIR__ . '/file/trait.php');
23+
}
2224
$loader->addDirectory(__DIR__ . '/files.robots');
2325
$loader->register();
2426

25-
Assert::false( class_exists('ConditionalClass') ); // files/conditional.class.php
26-
Assert::true( interface_exists('TestInterface') ); // file/interface.php
27-
if (PHP_VERSION_ID >= 50400) Assert::true( trait_exists('TestTrait') ); // file/trait.php
28-
29-
Assert::true( class_exists('TestClass') ); // files/namespaces1.php
30-
Assert::true( class_exists('MySpace1\TestClass1') ); // files/namespaces1.php
31-
Assert::true( class_exists('MySpace2\TestClass2') ); // files/namespaces2.php
32-
Assert::true( class_exists('MySpace3\TestClass3') ); // files/namespaces2.php
33-
34-
Assert::false( class_exists('Disallowed1') ); // files.robots\disallowed1\class.php
35-
Assert::false( class_exists('Disallowed2') ); // files.robots\disallowed2\class.php
36-
Assert::false( class_exists('Disallowed3') ); // files.robots\subdir\class.php
37-
Assert::true( class_exists('Allowed1') ); // files.robots\subdir\allowed.php
38-
Assert::false( class_exists('Disallowed4') ); // files.robots\subdir\disallowed4\class.php
39-
Assert::false( class_exists('Disallowed5') ); // files.robots\subdir\subdir2\disallowed5\class.php
40-
Assert::false( class_exists('Disallowed6') ); // files.robots\subdir\subdir2\class.php
41-
Assert::true( class_exists('Allowed2') ); // files.robots\subdir\subdir2\allowed.php
27+
Assert::false(class_exists('ConditionalClass')); // files/conditional.class.php
28+
Assert::true(interface_exists('TestInterface')); // file/interface.php
29+
if (PHP_VERSION_ID >= 50400) {
30+
Assert::true(trait_exists('TestTrait'));
31+
} // file/trait.php
32+
33+
Assert::true(class_exists('TestClass')); // files/namespaces1.php
34+
Assert::true(class_exists('MySpace1\TestClass1')); // files/namespaces1.php
35+
Assert::true(class_exists('MySpace2\TestClass2')); // files/namespaces2.php
36+
Assert::true(class_exists('MySpace3\TestClass3')); // files/namespaces2.php
37+
38+
Assert::false(class_exists('Disallowed1')); // files.robots\disallowed1\class.php
39+
Assert::false(class_exists('Disallowed2')); // files.robots\disallowed2\class.php
40+
Assert::false(class_exists('Disallowed3')); // files.robots\subdir\class.php
41+
Assert::true(class_exists('Allowed1')); // files.robots\subdir\allowed.php
42+
Assert::false(class_exists('Disallowed4')); // files.robots\subdir\disallowed4\class.php
43+
Assert::false(class_exists('Disallowed5')); // files.robots\subdir\subdir2\disallowed5\class.php
44+
Assert::false(class_exists('Disallowed6')); // files.robots\subdir\subdir2\class.php
45+
Assert::true(class_exists('Allowed2')); // files.robots\subdir\subdir2\allowed.php

tests/Loaders/RobotLoader.rebuild.phpt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
* Test: Nette\Loaders\RobotLoader rebuild only once.
55
*/
66

7-
use Nette\Loaders\RobotLoader,
8-
Nette\Caching\Storages\DevNullStorage,
9-
Tester\Assert;
7+
use Nette\Loaders\RobotLoader;
8+
use Nette\Caching\Storages\DevNullStorage;
9+
use Tester\Assert;
1010

1111

1212
require __DIR__ . '/../bootstrap.php';
@@ -26,4 +26,4 @@ $a = new A;
2626

2727
rename(TEMP_DIR . '/file2.php', TEMP_DIR . '/file4.php');
2828

29-
Assert::false( class_exists('B') );
29+
Assert::false(class_exists('B'));

tests/Loaders/RobotLoader.renamed.phpt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
* Test: Nette\Loaders\RobotLoader and renamed classes.
55
*/
66

7-
use Nette\Loaders\RobotLoader,
8-
Nette\Caching\Storages\DevNullStorage,
9-
Tester\Assert;
7+
use Nette\Loaders\RobotLoader;
8+
use Nette\Caching\Storages\DevNullStorage;
9+
use Tester\Assert;
1010

1111

1212
require __DIR__ . '/../bootstrap.php';

0 commit comments

Comments
 (0)