revert to v3.2.1

Author: dg

src/RobotLoader/RobotLoader.php

@@ -411,51 +411,37 @@ public function setTempDirectory(string $dir): self
 	private function loadCache(): void
 	{
 		$file = $this->getCacheFile();
-		$handle = fopen($file, 'cb+');
-		if (!$handle || !flock($handle, LOCK_SH)) {
-			throw new \RuntimeException("Unable to create or acquire shared lock on file '$file'.");
-		}
-
-		$data = include $file;
-		if (is_array($data)) {
-			[$this->classes, $this->missing] = $data;
+		[$this->classes, $this->missing] = @include $file; // @ file may not exist
+		if (is_array($this->classes)) {
 			return;
 		}
 
-		if (!flock($handle, LOCK_EX)) {
-			throw new \RuntimeException("Unable to create or acquire exclusive lock on file '$file'.");
+		$handle = fopen("$file.lock", 'cb+');
+		if (!$handle || !flock($handle, LOCK_EX)) {
+			throw new \RuntimeException("Unable to create or acquire exclusive lock on file '$file.lock'.");
 		}
 
-		// while waiting for the lock, someone might have already created the cache
-		if (fstat($handle)['size']) {
-			flock($handle, LOCK_SH);
-			$data = include $file;
-			if (is_array($data)) {
-				[$this->classes, $this->missing] = $data;
-				return;
-			}
+		[$this->classes, $this->missing] = @include $file; // @ file may not exist
+		if (!is_array($this->classes)) {
+			$this->rebuild();
 		}
 
-		$this->classes = $this->missing = [];
-		$this->refreshClasses();
-		$this->saveCache($handle);
+		flock($handle, LOCK_UN);
+		fclose($handle);
+		@unlink("$file.lock"); // @ file may become locked on Windows
 	}
 
 
 	/**
 	 * Writes class list to cache.
 	 */
-	private function saveCache($handle = null): void
+	private function saveCache(): void
 	{
 		$file = $this->getCacheFile();
-		$handle = $handle ?: fopen($file, 'cb+');
-		if (!$handle || !flock($handle, LOCK_EX)) {
-			throw new \RuntimeException("Unable to create or acquire exclusive lock on file '$file'.");
-		}
-
+		$tempFile = $file . uniqid('', true) . '.tmp';
 		$code = "<?php\nreturn " . var_export([$this->classes, $this->missing], true) . ";\n";
-		if (!ftruncate($handle, 0) || fwrite($handle, $code) !== strlen($code)) {
-			@unlink($file); // @ - the locked file may not be deleted
+		if (file_put_contents($tempFile, $code) !== strlen($code) || !rename($tempFile, $file)) {
+			@unlink($tempFile); // @ - file may not exist
 			throw new \RuntimeException("Unable to create '$file'.");
 		}
 		if (function_exists('opcache_invalidate')) {