SimpleRouter: uses loose comparison == for default values since PHP 8.0

xificurk · dg · commit 8d7c91d3dcbf · 2024-11-04T12:59:53.000+01:00
diff --git a/src/Routing/SimpleRouter.php b/src/Routing/SimpleRouter.php
@@ -44,9 +44,7 @@ public function constructUrl(array $params, Nette\Http\UrlScript $refUrl): ?stri
 	{
 		// remove default values; null values are retain
 		foreach ($this->defaults as $key => $value) {
-			if (isset($params[$key])
-				&& (is_scalar($params[$key]) ? (string) $params[$key] : $params[$key]) === (is_scalar($value) ? (string) $value : $value)
-			) {
+			if (isset($params[$key]) && $params[$key] == $value) { // default value may be object, intentionally ==
 				unset($params[$key]);
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -44,9 +44,7 @@ public function constructUrl(array $params, Nette\Http\UrlScript $refUrl): ?stri`
`44`	`44`	`{`
`45`	`45`	`// remove default values; null values are retain`
`46`	`46`	`foreach ($this->defaults as $key => $value) {`
`47`		`- if (isset($params[$key])`
`48`		`- && (is_scalar($params[$key]) ? (string) $params[$key] : $params[$key]) === (is_scalar($value) ? (string) $value : $value)`
`49`		`- ) {`
	`47`	`+ if (isset($params[$key]) && $params[$key] == $value) { // default value may be object, intentionally ==`
`50`	`48`	`unset($params[$key]);`
`51`	`49`	`}`
`52`	`50`	`}`